xpra icon
Bug tracker and wiki

Opened 4 weeks ago

Closed 3 weeks ago

#2839 closed enhancement (fixed)

handle 16 and 30-bit pixels in cairo backend

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 4.1
Component: client Version: 3.0.x
Keywords: Cc:

Description

Similar to #2828 but for the non-opengl case.

Attachments (1)

csc_cython-GBRP10_to_r210.patch​ (7.0 KB) - added by Antoine Martin 4 weeks ago.
adds GBRP10_to_r210 to csc_cython

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 weeks ago by Antoine Martin

Status: new → assigned

Done in r26951 for plain "r210" (aka RGB30).

Still TODO:

  • actually test on 30-bit displays and verify that the extra 2 bits of pixel depth are used
  • convert GBRP10 to r210 via csc_cython so that we can use h264
  • maybe also add FORMAT_RGB16_565?
Last edited 4 weeks ago by Antoine Martin (previous) (diff)

Changed 4 weeks ago by Antoine Martin

Attachment: csc_cython-GBRP10_to_r210.patch​ added

adds GBRP10_to_r210 to csc_cython

comment:2 Changed 4 weeks ago by Antoine Martin

The resulting picture is only half the height!? (reading more segfaults)
Is it the decoder or the csc that is wrong?

comment:3 Changed 4 weeks ago by Antoine Martin

Summary: handle 30-bit pixels in cairo backend → handle 16 and 30-bit pixels in cairo backend

r26956 + r26957 adds support for 16-bit BGR565 pixels (aka cairo.FORMAT_RGB16_565)

comment:4 Changed 3 weeks ago by Antoine Martin

Resolution: → fixed
Status: assigned → closed

r26960 does the conversion from GBRP10 to r210 which allows us to handle 10-bit video in both opengl and non-opengl cases.

All looks good, except on win32 (headerbar bug): ticket:2539#comment:20.

Note: See TracTickets for help on using tickets.