#2877 closed defect (fixed)
Websocket header case sensitivity
Reported by: | Mark Harkin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | major | Milestone: | 4.1 |
Component: | client | Version: | 3.0.x |
Keywords: | Cc: |
Description
Traefik2 chooses to use lower case 's' in 'Sec-Websocket-Accept' 'Sec-Websocket-Protocol'. This breaks xpra wss connection with traefik ssl termination. A little annoying but http header parsing should be case insensitive.
The below fix worked for me:
https://github.com/mjharkin/Xpra/commit/772eafb0164560fa0e8f4f574f383d80bd82f245
Change History (3)
comment:1 Changed 22 months ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 21 months ago by
Damn.
There is no CaseInsensitiveDict
in python2, so the backport broke all the python2 builds.
Fixed the lazy way (no support for case insensitive attributes with python2): r27624.
It also broke packaging on macos.
So at that point, I decided to just re-write it without using CaseInsensitiveDict
: r27626.
comment:3 Changed 17 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2877
Note: See
TracTickets for help on using
tickets.
Thanks!
Applied in r27480.