#2878 closed defect (fixed)
Xpra-Launcher not respecting env variables
Reported by: | Mark Harkin | Owned by: | Mark Harkin |
---|---|---|---|
Priority: | major | Milestone: | 4.1 |
Component: | client | Version: | 3.0.x |
Keywords: | Cc: |
Description
Using trunk.
Launching with "Xpra-Launcher ..." doesn't respect env variables set in .xpra file but "Xpra launcher ..." does.
Thought I had hacked it to work with
https://github.com/mjharkin/Xpra/commit/f35109ca3bc5c96dc9cf35fad5a0d4665b4d6654
But tray env variables like XPRA_SHOW_WINDOWS_MENU still aren't respected and again this works with "Xpra launcher ..."
Think I'm definitely missing something here.
Change History (10)
comment:1 Changed 22 months ago by
Owner: | changed from Antoine Martin to Mark Harkin |
---|
comment:2 Changed 22 months ago by
Sorry should have made it more clear.
Xpra.exe launcher ... Works
Xpra-Launcher.exe ... Doesn't work.
comment:3 Changed 22 months ago by
Owner: | changed from Mark Harkin to Antoine Martin |
---|---|
Status: | new → assigned |
Ah, I see.
I don't see why the launcher config files could not include all options, including environment variables.
I think this comes from the import:
from xpra.client.gtk_base.gtk_tray_menu_base import make_encodingsmenu
This utility function should be moved elsewhere so we don't initialize the tray settings before we've had a chance to load the file and apply the settings.
comment:4 follow-up: 5 Changed 22 months ago by
Owner: | changed from Antoine Martin to Mark Harkin |
---|---|
Status: | assigned → new |
@mjharkin: sorry, not had time to test it - but does r27484 help?
comment:5 Changed 22 months ago by
Replying to Antoine Martin:
@mjharkin: sorry, not had time to test it - but does r27484 help?
Yes that fixed it, thanks.
comment:6 Changed 21 months ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 Changed 21 months ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Sorry, tested this ontop of my custom changes, I think r27484 only works with env vars in combination with https://github.com/mjharkin/Xpra/commit/f35109ca3bc5c96dc9cf35fad5a0d4665b4d6654 not sure if this is the correct place or way it should be done though.
comment:8 follow-up: 9 Changed 21 months ago by
r27598 looks like the correct fix to me - works here.
Why was your patch handling config.env
as a string?
env
is defined as a list, it should never be a string.
comment:9 Changed 21 months ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Replying to Antoine Martin:
r27598 looks like the correct fix to me - works here.
Thanks looks good, closing again.
Why was your patch handling
config.env
as a string?
env
is defined as a list, it should never be a string.
No idea, just assumed incorrectly.
comment:10 Changed 17 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2878
Is this a typo perhaps?
What is the difference between "Xpra-Launcher ..." and "Xpra-Launcher ..." ?