Cannot connect with r27603 v2

[stdedos]

With r27616 I get:

"Xpra-Python3-x86_64_4.1-r27616\xpra_cmd" shadow ssh://user@ip/0 --ssh="plink -ssh -agent" -d ssh --env=XPRA_SHADOW_REFRESH_DELAY=200 --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps --desktop-scaling=0.75 --webcam=no --speaker=off --microphone=off --pulseaudio=no

args=--ssh="plink -ssh -agent" -d ssh --env=XPRA_SHADOW_REFRESH_DELAY=200 --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps --desktop-scaling=0.75 --webcam=no --speaker=off --microphone=off --pulseaudio=no
XPRA_CUSTOM_TITLE_BAR=0
XPRA_EXECUTABLE=Xpra-Python3-x86_64_4.1-r27616
XPRA_NETWORK_ADAPTER_TYPE=wifi
XPRA_SCROLL_ENCODING=0

2020-10-16 11:50:51,355 parse_ssh_string(plink -ssh -agent)
2020-10-16 11:50:52,281 Xpra GTK3 client version 4.1-r27616 64-bit
2020-10-16 11:50:52,283  running on Microsoft Windows 10
2020-10-16 11:50:53,223 GStreamer version 1.18.0 for Python 3.8.6 64-bit
2020-10-16 11:50:53,480 created named pipe 'Xpra\18840'
2020-10-16 11:50:53,810 keyboard layout code 0x409
2020-10-16 11:50:53,811 identified as 'United States - English' : us
2020-10-16 11:50:53,929 executing ssh command: "plink" "-ssh" "-agent" "-l" "u_lin" "-T" "ip" "sh -c 'if [ -x $XDG_RUNTIME_DIR/xpra/run-xpra ]; then $XDG_RUNTIME_DIR/xpra/run-xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif which "xpra" > /dev/null 2>&1; then xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x /usr/local/bin/xpra ]; then /usr/local/bin/xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x ~/.xpra/run-xpra ]; then ~/.xpra/run-xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x Xpra_cmd.exe ]; then Xpra_cmd.exe _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";else echo "no run-xpra command found"; exit 1; fi'"
2020-10-16 11:50:54,107  keyboard settings: layout=us
2020-10-16 11:50:54,113  desktop size is 4160x1440 with 1 screen:
2020-10-16 11:50:54,114   Default (1100x381 mm - DPI: 96x96) workarea: 4160x1400
2020-10-16 11:50:54,115     Generic PnP Monitor 1600x900 at 0x534 (309x174 mm - DPI: 131x131) workarea: 1600x860 at 0x534
2020-10-16 11:50:54,116     C32JG5x 2560x1440 at 1600x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400 at 1600x0
2020-10-16 11:50:54,117  downscaled to 75%, virtual screen size: 5547x1920
2020-10-16 11:50:54,119   Default (1100x381 mm - DPI: 128x128) workarea: 5547x1867
2020-10-16 11:50:54,121     Generic PnP Monitor 2133x1200 at 0x712 (309x174 mm - DPI: 175x175) workarea: 2133x1147 at 0x712
2020-10-16 11:50:54,123     C32JG5x 3413x1920 at 2133x0 (697x392 mm - DPI: 124x124) workarea: 3413x1867 at 2133x0
2020-10-16 11:51:01,176 Error: failed to receive anything, not an xpra server?
2020-10-16 11:51:01,180   could also be the wrong protocol, username, password or port
2020-10-16 11:51:01,181   or the session was not found
2020-10-16 11:51:01,182 Connection lost
Press any key to continue . . .

(same with r27676)

However, running this manually gives:

$ if [ -x $XDG_RUNTIME_DIR/xpra/run-xpra ]; then $XDG_RUNTIME_DIR/xpra/run-xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif which "xpra" > /dev/null 2>&1; then xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x /usr/local/bin/xpra ]; then /usr/local/bin/xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x ~/.xpra/run-xpra ]; then ~/.xpra/run-xpra _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";elif [ -x Xpra_cmd.exe ]; then Xpra_cmd.exe _proxy_shadow_start ":0" "--opengl=no" "--title=@title@ on @@/@server-display@" "--bandwidth-limit=6Mbps" "--ssh=plink -ssh -agent" "--desktop-scaling=0.75" "--debug=ssh" "--speaker=off" "--headerbar=off" "--env=XPRA_SHADOW_REFRESH_DELAY=200";else echo "no run-xpra command found"; exit 1; fi
xpra initialization error:
 no such option: --headerbar

Would you please sync those errors back on the client log? If you are somehow afraid of server-exposing-unnecessary-information-to-user-via-error thing, would you "at least" force a server log to be created and have these appended?

[Antoine Martin]

no such option: --headerbar

Should be fixed in r27677.

Would you please sync those errors back on the client log?

Ah, you're using putty rather than the default paramiko backend.

So I did a bit of digging and r3156 (7 years ago!) claims that we can't use sys.stderr on win32. (it was actually first added in r2762 - 8 years ago - but that commit doesn't state why)
So we were sending it to a pipe, which we then ignored, r27678 fixes that.

[stdedos]

Still a fix is wanted:

"Xpra-Python3-x86_64_4.1-r27695\xpra_cmd" attach ssh://user@ip/3 --ssh="plink -ssh -agent" --modal-windows=no --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps

XPRA_CUSTOM_TITLE_BAR=0
XPRA_EXECUTABLE=Xpra-Python3-x86_64_4.1-r27695
XPRA_REPAINT_ALL=1
XPRA_SCROLL_ENCODING=0

2020-10-19 11:19:28,990 Xpra GTK3 client version 4.1-r27695 64-bit
2020-10-19 11:19:28,992  running on Microsoft Windows 10
2020-10-19 11:19:31,367 GStreamer version 1.18.0 for Python 3.8.6 64-bit
2020-10-19 11:19:31,606 created named pipe 'Xpra\10308'
2020-10-19 11:19:31,833 keyboard layout code 0x409
2020-10-19 11:19:31,834 identified as 'United States - English' : us
2020-10-19 11:19:31,987 Warning: libqrencode not found
Exception in thread ssh-stderr-reader:
Traceback (most recent call last):
  File "C:/msys64/mingw64/lib/python3.8/threading.py", line 932, in _bootstrap_inner
  File "C:/msys64/mingw64/lib/python3.8/threading.py", line 870, in run
  File "E:\Xpra\trunk\src/xpra/net/ssh.py", line 974, in stderr_reader
TypeError: abort_test() missing 1 required positional argument: 'action'

[Antoine Martin]

Sorry about that.
How odd, I'm certain that I had tested this on win32 and Linux before the commit.
Anyway, r27699 fixes this.