xdg-open download file fails v2

[stdedos]

(After #2671)

"Xpra-Python3-x86_64_4.1-r27695\xpra_cmd" attach ssh://user@ip/3 --ssh="plink -ssh -agent" --modal-windows=no --title="@title@ on @@/@server-display@" --headerbar=off --opengl=no --bandwidth-limit=6Mbps

XPRA_CUSTOM_TITLE_BAR=0
XPRA_EXECUTABLE=Xpra-Python3-x86_64_4.1-r27695
XPRA_REPAINT_ALL=1
XPRA_SCROLL_ENCODING=0

2020-10-21 11:22:51,759 Xpra GTK3 client version 4.1-r27695 64-bit
2020-10-21 11:22:51,761  running on Microsoft Windows 10
2020-10-21 11:22:52,926 GStreamer version 1.18.0 for Python 3.8.6 64-bit
2020-10-21 11:22:53,267 created named pipe 'Xpra\22248'
2020-10-21 11:22:53,612 keyboard layout code 0x409
2020-10-21 11:22:53,614 identified as 'United States - English' : us
2020-10-21 11:22:53,788 Warning: libqrencode not found
Exception in thread ssh-stderr-reader:
Traceback (most recent call last):
  File "C:/msys64/mingw64/lib/python3.8/threading.py", line 932, in _bootstrap_inner
  File "C:/msys64/mingw64/lib/python3.8/threading.py", line 870, in run
  File "E:\Xpra\trunk\src/xpra/net/ssh.py", line 974, in stderr_reader
TypeError: abort_test() missing 1 required positional argument: 'action'
2020-10-21 11:22:53,924  keyboard settings: layout=us
2020-10-21 11:22:53,935  desktop size is 4160x1440 with 1 screen:
2020-10-21 11:22:53,937   Default (1100x381 mm - DPI: 96x96) workarea: 4160x1400
2020-10-21 11:22:53,938     Generic PnP Monitor 1600x900 at 0x534 (309x174 mm - DPI: 131x131) workarea: 1600x860 at 0x534
2020-10-21 11:22:53,938     C32JG5x 2560x1440 at 1600x0 (697x392 mm - DPI: 93x93) workarea: 2560x1400 at 1600x0
2020-10-21 11:22:57,960 enabled remote logging
2020-10-21 11:22:57,965 Xpra GTK3 X11 server version 3.0.12-r27620 64-bit
2020-10-21 11:22:57,966  running on Linux Ubuntu 16.04 xenial
2020-10-21 11:22:57,979 Attached to ip:22
2020-10-21 11:22:57,984  (press Control-C to detach)


(xpra_cmd:22248): Pango-WARNING **: 11:22:58.515: couldn't load font "Bitstream Vera Sans Not-Rotated 14.662109375", falling back to "Sans Not-Rotated 14.662109375", expect ugly output.
2020-10-21 11:22:59,553 UI thread is now blocked
2020-10-21 11:23:00,165 UI thread is running again, resuming
2020-10-21 11:23:13,054 Warning: static gravity is not handled
2020-10-21 11:52:27,883 Warning: failed to set clipboard data
2020-10-21 11:52:27,886  OpenClipboard: too many failed attempts, giving up
2020-10-21 11:52:39,731 Warning: failed to set clipboard data
2020-10-21 11:52:39,734  OpenClipboard: too many failed attempts, giving up
2020-10-21 11:52:52,864 Warning: failed to set clipboard data
2020-10-21 11:52:52,867  OpenClipboard: too many failed attempts, giving up
2020-10-21 11:53:02,697 Warning: failed to set clipboard data
2020-10-21 11:53:02,700  OpenClipboard: too many failed attempts, giving up
2020-10-21 11:59:22,052 Error: cannot cancel download 49d524a6395d44d3858df62f8f3b478b, entry not found!
2020-10-21 12:01:48,589 enabled debugging for:
2020-10-21 12:01:48,599  - Logger(xpra.client.gtk_base.gtk_client_base, gtk, client, file)
2020-10-21 12:01:48,605  - Logger(xpra.client.gtk_base.open_requests, gtk, file)
2020-10-21 12:01:48,611  - Logger(xpra.client.mixins.fileprint_mixin, file)
2020-10-21 12:01:48,614  - Logger(xpra.net.file_transfer, file)
2020-10-21 12:01:53,405 process send-data-request: send_id=b'e88c345d5aaa476ab3763f5a4c90252a', url=b'/home/sntentos/Documents/Forcepoint/Scripts/printscreen.bak', printit=False, openit=True
2020-10-21 12:01:53,443 show()
2020-10-21 12:01:55,607 accept(b'printscreen.bak', False, True)=1
2020-10-21 12:01:55,639 receiving file: [b'printscreen.bak', b'', False, False, 46184, '46184 bytes', {b'sha1': b'800731770c2fb11e66a7bc76ecdceb7a80bd2291', b'file-chunk-id': b'06f8058262a4446f941bb5674ce2d3f1'}]
2020-10-21 12:01:55,644 cannot save file as C:\Users\stavros.ntentos\Downloads\printscreen.bak: file already exists
2020-10-21 12:01:55,646 safe_open_download_file(printscreen.bak, b'') will use 'C:\Users\stavros.ntentos\Downloads\printscreen-1.bak'
2020-10-21 12:01:55,648 using filename 'C:\Users\stavros.ntentos\Downloads\printscreen-1.bak', file descriptor=4
2020-10-21 12:02:04,171 unknown string message: 0xc238 / 0x0 / 0x0
2020-10-21 12:02:05,651 _check_chunk_receiving(06f8058262a4446f941bb5674ce2d3f1, 0) chunk_state=[3463402.0140701826, 4, 'C:\\Users\\stavros.ntentos\\Downloads\\printscreen-1.bak', b'', False, False, 46184, {b'sha1': b'800731770c2fb11e66a7bc76ecdceb7a80bd2291', b'file-chunk-id': b'06f8058262a4446f941bb5674ce2d3f1'}, <sha1 HASH object @ 0x0000000008678a30>, 0, False, b'e88c345d5aaa476ab3763f5a4c90252a', 83227, 0]
2020-10-21 12:02:05,660 Error: chunked file transfer '06f8058262a4446f941bb5674ce2d3f1' timed out
2020-10-21 12:02:18,613 close()
2020-10-21 12:02:18,617 hide()
2020-10-21 12:02:18,626 cancel_download(b'e88c345d5aaa476ab3763f5a4c90252a', User cancelled)
2020-10-21 12:02:18,630 Error: cannot cancel download e88c345d5aaa476ab3763f5a4c90252a, entry not found!
2020-10-21 12:02:26,572 disabled debugging for:
2020-10-21 12:02:26,588  - Logger(xpra.client.gtk_base.gtk_client_base, gtk, client, file)
2020-10-21 12:02:26,592  - Logger(xpra.client.gtk_base.open_requests, gtk, file)
2020-10-21 12:02:26,595  - Logger(xpra.client.mixins.fileprint_mixin, file)
2020-10-21 12:02:26,599  - Logger(xpra.net.file_transfer, file)

2020-10-21 12:01:48,938 New unix-domain connection received
2020-10-21 12:01:48,938  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:01:48,939 enabled debugging for: Logger(xpra.server.mixins.fileprint_server, file), Logger(xpra.net.file_transfer, file)
2020-10-21 12:01:49,221 New unix-domain connection received
2020-10-21 12:01:49,221  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:01:49,248 client   6 @56.829 enabled debugging for:
2020-10-21 12:01:49,262 client   6 @56.838  - Logger(xpra.client.gtk_base.gtk_client_base, gtk, client, file)
2020-10-21 12:01:49,262 client   6 @56.845  - Logger(xpra.client.gtk_base.open_requests, gtk, file)
2020-10-21 12:01:49,320 client   6 @56.851  - Logger(xpra.client.mixins.fileprint_mixin, file)
2020-10-21 12:01:49,320 client   6 @56.853  - Logger(xpra.net.file_transfer, file)
2020-10-21 12:01:49,935 New unix-domain connection received
2020-10-21 12:01:49,935  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:01:49,935 New unix-domain connection received
2020-10-21 12:01:49,935  on '/run/xpra/u-h-3'
2020-10-21 12:01:50,219 New unix-domain connection received
2020-10-21 12:01:50,219  on '/run/xpra/u-h-3'
2020-10-21 12:01:50,220 New unix-domain connection received
2020-10-21 12:01:50,220  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:01:54,041 New unix-domain connection received
2020-10-21 12:01:54,041  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:01:54,042 send_file('/path/printscreen.bak', '', <class 'bytes'>, '46184 bytes', False, True, {'sha1': '800731770c2fb11e66a7bc76ecdceb7a80bd2291', 'file-chunk-id': '06f8058262a4446f941bb5674ce2d3f1'}) action=open, ask=True
2020-10-21 12:01:54,042 file transfer remote caps: file-transfer=True   (ask=True)
2020-10-21 12:01:54,042 file transfer remote caps: printing=True        (ask=False)
2020-10-21 12:01:54,042 file transfer remote caps: open-files=True      (ask=True)
2020-10-21 12:01:54,043 file transfer remote caps: open-url=True        (ask=True)
2020-10-21 12:01:54,043 sending data request for file '/path/printscreen.bak' with send-id=e88c345d5aaa476ab3763f5a4c90252a
2020-10-21 12:01:54,061 client   6 @01.644 process send-data-request: send_id=b'e88c345d5aaa476ab3763f5a4c90252a', url=b'/path/printscreen.bak', printit=False, openit=True
2020-10-21 12:01:54,095 client   6 @01.682 show()
2020-10-21 12:01:56,259 client   6 @03.846 accept(b'printscreen.bak', False, True)=1
2020-10-21 12:01:56,275 process send-data-response: send_id=b'e88c345d5aaa476ab3763f5a4c90252a', accept=1
2020-10-21 12:01:56,275 do_send_file('/path/printscreen.bak', '', <class 'bytes'>, '46184 bytes', False, True, {'sha1': '800731770c2fb11e66a7bc76ecdceb7a80bd2291', 'file-chunk-id': '06f8058262a4446f941bb5674ce2d3f1'})
2020-10-21 12:01:56,276 sha1 digest(/path/printscreen.bak)=800731770c2fb11e66a7bc76ecdceb7a80bd2291
2020-10-21 12:01:56,295 client   6 @03.878 receiving file: [b'printscreen.bak', b'', False, False, 46184, '46184 bytes', {b'sha1': b'800731770c2fb11e66a7bc76ecdceb7a80bd2291', b'file-chunk-id': b'06f8058262a4446f941bb5674ce2d3f1'}]
2020-10-21 12:01:56,350 client   6 @03.883 cannot save file as ~\Downloads\printscreen.bak: file already exists
2020-10-21 12:01:56,350 client   6 @03.885 safe_open_download_file(printscreen.bak, b'') will use '~\Downloads\printscreen-1.bak'
2020-10-21 12:01:56,350 client   6 @03.887 using filename '~\Downloads\printscreen-1.bak', file descriptor=4
2020-10-21 12:01:56,350 ack-file-chunk: [b'06f8058262a4446f941bb5674ce2d3f1', True, b'', 0]
2020-10-21 12:01:56,350 Error: cannot find the file transfer id '06f8058262a4446f941bb5674ce2d3f1'
2020-10-21 12:02:04,908 client   6 @12.410 unknown string message: 0xc238 / 0x0 / 0x0
2020-10-21 12:02:06,315 client   6 @13.890 _check_chunk_receiving(06f8058262a4446f941bb5674ce2d3f1, 0) chunk_state=[3463402.0140701826, 4, '~\\Downloads\\printscreen-1.bak', b'', False, False, 46184, {b'sha1': b'800731770c2fb11e66a7bc76ecdceb7a80bd2291', b'f
ile-chunk-id': b'06f8058262a4446f941bb5674ce2d3f1'}, <sha1 HASH object @ 0x0000000008678a30>, 0, False, b'e88c345d5aaa476ab3763f5a4c90252a', 83227, 0]
2020-10-21 12:02:06,316 client   6 @13.899 Error: chunked file transfer '06f8058262a4446f941bb5674ce2d3f1' timed out
2020-10-21 12:02:19,268 client   6 @26.852 close()
2020-10-21 12:02:19,281 client   6 @26.856 hide()
2020-10-21 12:02:19,281 client   6 @26.865 cancel_download(b'e88c345d5aaa476ab3763f5a4c90252a', User cancelled)
2020-10-21 12:02:19,295 client   6 @26.869 Error: cannot cancel download e88c345d5aaa476ab3763f5a4c90252a, entry not found!
2020-10-21 12:02:26,886 New unix-domain connection received
2020-10-21 12:02:26,886  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:02:26,887 disabled debugging for: Logger(xpra.server.mixins.fileprint_server, file), Logger(xpra.net.file_transfer, file)
2020-10-21 12:02:27,193 New unix-domain connection received
2020-10-21 12:02:27,193  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:02:27,226 client   6 @34.810 disabled debugging for:
2020-10-21 12:02:27,252 client   6 @34.826  - Logger(xpra.client.gtk_base.gtk_client_base, gtk, client, file)
2020-10-21 12:02:27,252 client   6 @34.830  - Logger(xpra.client.gtk_base.open_requests, gtk, file)
2020-10-21 12:02:27,252 client   6 @34.834  - Logger(xpra.client.mixins.fileprint_mixin, file)
2020-10-21 12:02:27,265 client   6 @34.839  - Logger(xpra.net.file_transfer, file)
2020-10-21 12:02:27,884 New unix-domain connection received
2020-10-21 12:02:27,884  on '/run/xpra/u-h-3'
2020-10-21 12:02:27,884 New unix-domain connection received
2020-10-21 12:02:27,884  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:02:28,192 New unix-domain connection received
2020-10-21 12:02:28,192  on '/run/user/1000/xpra/u-h-3'
2020-10-21 12:02:28,192 New unix-domain connection received
2020-10-21 12:02:28,192  on '/run/xpra/u-h-3'

File is plain text file (tmux printscreen from a console), attached redacted (still fails to come)

[Antoine Martin]

OH, I've just seen the problem, only with 3.x servers but then when I installed from source the problem went away..
Then I re-installed the server with apt, and still no dice!?

I did find a few minor things: r27758, r27739.

And now I really cannot get it to misbehave, can you?

[stdedos]

I tried updating the client, which did not work.

Then, as you did: I re-installed the xpra server (apt-get install --reinstall xpra python3-xpra), did xpra upgrade, and after that ... it worked 😕

Another heisenbug? 😕

Anyway, lgtm, works. idk if you want it closed as fixed or worksforme