Xpra: Ticket #292: Win32 build fails with x264_ENABLED=False


if I set x264_ENABLED to False in setup.py, and try to build Xpra, the build fails. Error message screenshot attached, build log attached.

Wed, 13 Mar 2013 10:14:31 GMT - ahuillet: attachment set

Wed, 13 Mar 2013 10:14:37 GMT - ahuillet: attachment set

Wed, 13 Mar 2013 10:18:38 GMT - Antoine Martin:

I don't see how that is possible:

IF %X264% NEQ 1 GOTO NO_X264
SET X264_CODEC_PYD=build\lib.win32-2.7\xpra\x264\codec.pyd
COPY %X264_CODEC_PYD% xpra\x264\
if %errorlevel% NEQ 0 (
	ECHO "build error: cannot find compiled x264 codec.pyd"

If you set X264 to any value but 1, this line will never be run as it will skip straight to NO_X264. Feel free to add echo statements to verify.

Unless.... you modified the setup.py instead of the BAT file?

Wed, 13 Mar 2013 10:23:46 GMT - ahuillet: status changed; resolution set

Sat, 23 Jan 2021 04:50:47 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/292