xpra icon
Bug tracker and wiki

Opened 7 years ago

Closed 7 years ago

#292 closed defect (invalid)

Win32 build fails with x264_ENABLED=False

Reported by: ahuillet Owned by:
Priority: major Milestone:
Component: packaging Version:
Keywords: Cc:

Description

Hello,

if I set x264_ENABLED to False in setup.py, and try to build Xpra, the build fails. Error message screenshot attached, build log attached.

Attachments (2)

build-xpra.log (10.9 KB) - added by ahuillet 7 years ago.
win32build.jpg (71.6 KB) - added by ahuillet 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by ahuillet

Attachment: build-xpra.log added

Changed 7 years ago by ahuillet

Attachment: win32build.jpg added

comment:1 Changed 7 years ago by Antoine Martin

I don't see how that is possible:

IF %X264% NEQ 1 GOTO NO_X264
SET X264_CODEC_PYD=build\lib.win32-2.7\xpra\x264\codec.pyd
COPY %X264_CODEC_PYD% xpra\x264\
if %errorlevel% NEQ 0 (
	ECHO "build error: cannot find compiled x264 codec.pyd"
	GOTO ERROR
)
:NO_X264

If you set X264 to any value but 1, this line will never be run as it will skip straight to NO_X264. Feel free to add echo statements to verify.

Unless.... you modified the setup.py instead of the BAT file?

comment:2 Changed 7 years ago by ahuillet

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.