xpra icon
Bug tracker and wiki

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#423 closed defect (fixed)

New tab in maximized browser causes window to resize to original size before maximize

Reported by: Smo Owned by: SmO
Priority: critical Milestone: 0.10
Component: client Version: trunk
Keywords: Cc:

Description

Fairly easy to reproduce in Firefox or Google-Chrome.

  • Open new browser (firefox or chrome)
  • Click on maximize in the top right corner
  • Open a new tab
  • Browser returns to same size prior to maximizing

Will provide debugging info if needed.

Change History (5)

comment:1 Changed 6 years ago by Antoine Martin

Component: androidclient
Milestone: 0.10
Priority: majorcritical

comment:2 Changed 6 years ago by Antoine Martin

Owner: changed from Antoine Martin to SmO

There are actually two bugs here:

  • r4274 fixes an important bug which caused the symptoms in this bug: firefox updates its window title when we create a new tab and that drops us out of maximized state
  • unfixed: we do not properly synchronize the "maximized" state between the client and server. At the moment this is only set as a client_property which is sent to the server but not used directly there: the server does not propagate this to its own model... and so as far as the server is concerned, it isn't maximized, it is just very big. Fixing this is non-trivial though.. so this will have to do for now.

Please confirm that this fixes your issue - and more importantly that it does not cause any undesired side-effects with the other metadata properties that could be affected by the change:

  • window icons
  • window title

etc..

Then I can apply to the 0.10.x branch asap.

comment:3 Changed 6 years ago by Smo

It appears to have fixed the problem. Probably needs more testing to be sure but I will update when I have done so.

comment:4 Changed 6 years ago by alas

I can't find any side-effects with this fix. should be good to 0.10.x

comment:5 Changed 6 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Was included in 0.10.3 release - closing.


See also #518 (unrelated, but same symptoms)

Last edited 6 years ago by Antoine Martin (previous) (diff)
Note: See TracTickets for help on using tickets.