xpra icon
Bug tracker and wiki

Opened 7 years ago

Closed 7 years ago

#427 closed defect (fixed)

draw decode failure when attaching to older remote

Reported by: أحمد المحمودي Owned by: Antoine Martin
Priority: major Milestone:
Component: client Version:
Keywords: Cc:

Description

When attaching xpra client (version 0.10.4) to an older ssh'd xpra session (0.3.11) I get white windows, and rolling error logs of form...

2013-09-11 09:20:16,643 draw error                             
Traceback (most recent call last):                              
  File "/usr/lib/python2.7/dist-packages/xpra/client/ui_client_base.py", line 1278, in _do_draw
    window.draw_region(x, y, width, height, coding, data, rowstride, packet_sequence, options, [record_decode_time])
  File "/usr/lib/python2.7/dist-packages/xpra/client/client_window_base.py", line 272, in draw_region
     self._backing.draw_region(x, y, width, height, coding, img_data, rowstride, options, callbacks)
  File "/usr/lib/python2.7/dist-packages/xpra/client/window_backing_base.py", line 381, in draw_region
    self.paint_with_video_decoder(dec_avcodec, "x264", img_data, x, y, width, height, options, callbacks)
  File "/usr/lib/python2.7/dist-packages/xpra/client/window_backing_base.py", line 231, in paint_with_video_decoder
    assert input_colorspace is not None, "csc was not specified and we cannot find a colorspace from csc_pixel_format=%s" % old_csc_fmt
AssertionError: csc was not specified and we cannot find a colorspace from csc_pixel_format=None

Change History (1)

comment:1 Changed 7 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Hmmm, I have added a workaround for trunk in r4327, but this isn't a satisfactory solution because it makes a big assumption when the csc format is missing.
Really, the only true solution is to not use a broken version which is not supported and has not received a single update for over a year. (this particular bug is just the tip of the iceberg)

But I've mentioned that many times before and nothing has changed, so maybe newer versions will just drop backwards compatibility with versions that are known to be buggy and broken, saving us crappy workarounds and broken code. That was always planned, this just raises the urgency somewhat.

Note: See TracTickets for help on using tickets.