xpra icon
Bug tracker and wiki

Changes between Initial Version and Version 1 of Ticket #475, comment 4


Ignore:
Timestamp:
12/17/13 16:47:39 (7 years ago)
Author:
Antoine Martin
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #475, comment 4

    initial v1  
    1 * The [/attachment/ticket/475/xshm-fixleak.patch xshm-fixleak.patch] is valid and important: applied in r4962. Should be backported.
     1* The [/attachment/ticket/475/xshm-fixleak.patch xshm-fixleak.patch] is valid and important: applied in r4962.
    22
    33* The reference issue was a red herring: it is not  illegal to have more than one {{{XShm}}} handle for the same pixmap, just a bit wasteful - but in our case they will be of different sizes, which is why we need them. The [/attachment/ticket/475/xshm-single.patch] implements a one-mapping-per-window policy, this makes things slower for no real benefit.
     
    66
    77* The real problem comes from how we free the image wrapper class, which in turn may free the xshm wrapper if it is waiting to be closed: this call may come from another thread - and non-UI threads are not allowed to talk to the X11 server!
    8 Fixed in r4963 - '''must''' be backported.
     8Fixed in r4963.
     9
     10
     11----
     12
     130.10.x backports in: r4965 and r4966 - keeping ticket opened for testing.