#491 closed defect (fixed)
webp is leaking memory
| Reported by: | Antoine Martin | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | major | Milestone: | 0.13 |
| Component: | client | Version: | |
| Keywords: | Cc: |
Description (last modified by )
See ticket:457#comment:30 - this is a client side leak only (I think), which affects all platforms.
Probably keeping references to some buffers somewhere (create_string_buffer?)
Fix it so we can actually use webp (and fix #487), and use it for more things. (ie: #419)
r5167 adds a big warning for anyone trying to use webp, will need to be removed if/when we figure this out
Change History (7)
comment:1 Changed 7 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | changed from Antoine Martin to Antoine Martin |
| Status: | new → assigned |
comment:2 Changed 7 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 7 years ago by
| Milestone: | 0.12 → 0.13 |
|---|
comment:4 Changed 7 years ago by
- leak fixed in r5945
- remove leak warnings and re-add webp as a valid lossless encoding to switch to in r5951
- refuse to use webp unless the client tell us it is not going to leak in r5955
All will need to be backported.
webp support via PIL was added in:
- r5937 for encoding
- r5936 for decoding (r5953 ensures we don't use Pillow for decoding webp for now - we can lift this restriction with a version check once upstream fixes the bug)
Pillow also leaks like we used to! (see r5952)
Bug reported upstream: Pillow issue 586
comment:5 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Backports for v0.12.x in r5956. Closing.
comment:6 Changed 7 years ago by
Note: the new webp cython encoder in 0.13 was also leaking memory, this is fixed in r6505.
comment:7 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/491
copyleft 2010 - 2021
re-scheduling all webp stuff