xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 2 years ago

Last modified 4 weeks ago

#494 closed enhancement (fixed)

file channel for upload/download from server

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: minor Milestone: 0.15
Component: core Version:
Keywords: Cc:

Description

Sometimes I miss the ability to easily exchange files between the xpra client and its server.
After all, we already have an authenticated connection and a GUI, why would I need to open an ssh channel (which may not be possible) to transfer more data than I can fit on a clipboard.

This could have other uses beyond simple file exchange: printing and configuration come to mind.

Wishlist:

  • both upload and download - both configurable, and probably disabled by default
  • client may have the option of showing a dialog to accept files before starting the transfer (and choose download location?)
  • API for sending a bunch of files together with ACK packets
  • send each file with its mimetype only, and maybe a named icon / icon data? (which should be cached)
  • each file needs to be chunked so we can interleave regular xpra traffic
  • ability to cancel transfers in progress
  • xpra control interface for sending from server
  • xpra tray UI for sending from client

etc.

Change History (9)

comment:1 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to Antoine Martin
Status: newassigned

comment:2 Changed 4 years ago by Antoine Martin

Milestone: 0.121.0

No time for this. Re-scheduling.

comment:3 Changed 3 years ago by Antoine Martin

Milestone: 1.00.15

Scheduling for v0.15.x

comment:4 Changed 2 years ago by Antoine Martin

Owner: changed from Antoine Martin to alas
Status: assignednew

Most of this code was already available in 0.15 for supporting wiki/Printing, see #598.
More updates in 0.16: see r11157. (some of these fixes will need to be backported)

Added a new wiki page: wiki/FileTransfers

@afarr FYI: you can now easily upload files to the server using the new tray menu entry "file upload".
And if the configuration option open-files is enabled, also open them in one go as the file selection dialog should then include an "open" option as well as "ok".

The remaining tasks of this ticket have been moved to #1026. Unless anything is badly broken, please close and add to #1026.

Last edited 2 years ago by Antoine Martin (previous) (diff)

comment:5 Changed 2 years ago by J. Max Mena

Resolution: fixed
Status: newclosed

Tested Win8.1, Fedora 20, and OSX clients:

  • All is working as expected...except if I attempt to send a large file, the client closes with an error(?) - Will leave comment in #1026.

Closing.

comment:6 Changed 2 years ago by Antoine Martin

Resolution: fixed
Status: closedreopened

Moving comment originally recorded in #1026: this needs to be fixed for this release (kicking clients is not good!).

attempted to upload a 7MB PNG image (random 1440p screenshot), server kicked my client with the following error: server requested disconnect: packet size requested is 4990193 but maximum allowed is 1048576


This should be fixed in r11179. (forgot to bump the max-packet-size limit in the client-to-server direction when file transfers are enabled).

We do not show an alert message for now, a warning is logged to the client output (usually also mirrored in the server log).


I also suspect people will want file size limits with regards to uploads.


We already have those limits in the config file, see wiki/FileTransfers


@maxmylyn: please close unless you can break it again.

comment:7 Changed 2 years ago by Antoine Martin

Owner: changed from alas to J. Max Mena
Status: reopenednew

comment:8 Changed 2 years ago by alas

Owner: changed from J. Max Mena to Antoine Martin

Re-tested with windows client 0.16.0 r11185 against a fedora 21 0.16.0 r11185 server.

I uploaded a 7 MB screenshot to the server with no problem.

  • Server gave notification:
2015-11-11 13:42:31,098 downloaded 7688761 bytes to unknown file:
2015-11-11 13:42:31,099  /home/tlaloc/Downloads/ginormous-professor-elemental-screenshot.PNG
  • Client gave what I assume is an unrelated warning:
C:\Program Files (x86)\Xpra\library.zip\xpra\client\gtk_base\gtk_client_base.py:160: GtkWarning: Could not find the icon 'gtk-file'. The 'hicolor' theme was not found either, perhaps you need to install it.
You can get a copy from:
        http://icon-theme.freedesktop.org/releases

Then went crazy and tried to upload a 38 MB file (without bothering to change config). Client balked with the presumably expected message:

2015-11-11 13:44:26,737 Warning: cannot upload the file 'blah-blah-blah'
2015-11-11 13:44:26,737  this file is too large: 38MB
Traceback (most recent call last):
  File "logging\__init__.pyc", line 859, in emit
  File "logging\__init__.pyc", line 732, in format
  File "logging\__init__.pyc", line 471, in format
  File "logging\__init__.pyc", line 335, in getMessage
TypeError: %d format: a number is required, not XpraClient
Logged from file log.pyc, line 100

This didn't cause any client disconnection though.

Since I'm not sure the Traceback here is expected though, I'll pass this back to you, rather than trying to close it again.

comment:9 Changed 2 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Client gave what I assume is an unrelated warning:


It is related, added: ticket:1026#comment:2


Since I'm not sure the Traceback here is expected though


It was not, fixed in r11193.

Closing, will follow up in #1026 for the next release. See also #1493.

Wiki: wiki/FileTransfers.

Last edited 4 weeks ago by Antoine Martin (previous) (diff)
Note: See TracTickets for help on using tickets.