xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#495 closed defect (fixed)

Windows: Uninstaller will run and "uninstall" while Xpra is still running

Reported by: J. Max Mena Owned by: J. Max Mena
Priority: minor Milestone: 0.12
Component: platforms Version: 0.10.x
Keywords: win32 installer Cc:

Description

In Windows, the uninstaller from:

Control Panel -> Programs, etc. ->Uninstall a Program

will open the uninstaller, which goes through the process of uninstalling Xpra. Before finishing, a message pops up saying not everything could be deleted.

After closing it and navigating to C:/Program Files (x86)/Xpra, all the files look intact. Also, the installer will ask to close Xpra before letting you install it.

The uninstaller should do a check to make sure Xpra has been closed.

Change History (6)

comment:1 Changed 4 years ago by Antoine Martin

Component: coreplatforms
Keywords: win32 installer added; Windows uninstaller removed
Milestone: 0.12
Owner: changed from Antoine Martin to Antoine Martin
Status: newassigned

This will require an NSIS plugin and checking the process name (just checking the main xpra_cmd.exe or xpra.exe, not all the other tools): NSIS Check whether your application is running using the name of the process, as we can't rely on the other options.

The same check should apply to the installer (upgrade) and uninstaller.

comment:2 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

The link in comment:1 would have been useful if we had been using NSIS... but since we're using InnoSetup instead, here is a solution based on:

We only check for 3 process names: Xpra.exe, Xpra_cmd.exe and Xpra-Launcher.exe. So if the users somehow finds his way to one of the other EXE files (ie: Encoding_info.exe, GStreamer_info.exe...) they will still get the error/warning, we will have to assume they are clever enough to figure it out from there.

comment:3 Changed 3 years ago by Smo

I can help do this. Just not sure where to place psvince.dll.

comment:4 Changed 3 years ago by Antoine Martin

Oops, it's already done, the changeset for this is r5362.

comment:5 Changed 3 years ago by J. Max Mena

Retested with r5828, uninstaller shows a pop-up that tells the user they must stop Xpra before uninstalling.

comment:6 Changed 3 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Done!

PS: caused #560

Last edited 3 years ago by Antoine Martin (previous) (diff)
Note: See TracTickets for help on using tickets.