#495 closed defect (fixed)
Windows: Uninstaller will run and "uninstall" while Xpra is still running
Reported by: | J. Max Mena | Owned by: | J. Max Mena |
---|---|---|---|
Priority: | minor | Milestone: | 0.12 |
Component: | platforms | Version: | 0.10.x |
Keywords: | win32 installer | Cc: |
Description
In Windows, the uninstaller from:
Control Panel -> Programs, etc. ->Uninstall a Program
will open the uninstaller, which goes through the process of uninstalling Xpra. Before finishing, a message pops up saying not everything could be deleted.
After closing it and navigating to C:/Program Files (x86)/Xpra
, all the files look intact. Also, the installer will ask to close Xpra before letting you install it.
The uninstaller should do a check to make sure Xpra has been closed.
Change History (7)
comment:1 Changed 7 years ago by
Component: | core → platforms |
---|---|
Keywords: | win32 installer added; Windows uninstaller removed |
Milestone: | → 0.12 |
Owner: | changed from Antoine Martin to Antoine Martin |
Status: | new → assigned |
comment:2 Changed 7 years ago by
Owner: | changed from Antoine Martin to J. Max Mena |
---|---|
Status: | assigned → new |
The link in comment:1 would have been useful if we had been using NSIS... but since we're using InnoSetup instead, here is a solution based on:
- How to check with inno-setup, if a process is running at a windows 2008 r2 64bit? (for the WMI process check solution)
- InnoSetup: Check if Revit is running (for the while retry loop)
We only check for 3 process names: Xpra.exe
, Xpra_cmd.exe
and Xpra-Launcher.exe
. So if the users somehow finds his way to one of the other EXE files (ie: Encoding_info.exe
, GStreamer_info.exe
...) they will still get the error/warning, we will have to assume they are clever enough to figure it out from there.
comment:5 Changed 7 years ago by
Retested with r5828, uninstaller shows a pop-up that tells the user they must stop Xpra before uninstalling.
comment:7 Changed 3 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/495
This will require an NSIS plugin and checking the process name (just checking the main
xpra_cmd.exe
orxpra.exe
, not all the other tools): NSIS Check whether your application is running using the name of the process, as we can't rely on the other options.The same check should apply to the installer (upgrade) and uninstaller.