Windows: Uninstaller will run and "uninstall" while Xpra is still running

[J. Max Mena]

In Windows, the uninstaller from:

Control Panel -> Programs, etc. ->Uninstall a Program

will open the uninstaller, which goes through the process of uninstalling Xpra. Before finishing, a message pops up saying not everything could be deleted.

After closing it and navigating to C:/Program Files (x86)/Xpra, all the files look intact. Also, the installer will ask to close Xpra before letting you install it.

The uninstaller should do a check to make sure Xpra has been closed.

[Antoine Martin]

This will require an NSIS plugin and checking the process name (just checking the main xpra_cmd.exe or xpra.exe, not all the other tools): ​NSIS Check whether your application is running using the name of the process, as we can't rely on the other options.

The same check should apply to the installer (upgrade) and uninstaller.

[Antoine Martin]

The link in comment:1 would have been useful if we had been using NSIS... but since we're using ​InnoSetup instead, here is a solution based on:

• ​How to check with inno-setup, if a process is running at a windows 2008 r2 64bit? (for the WMI process check solution)
• ​InnoSetup: Check if Revit is running (for the while retry loop)

We only check for 3 process names: Xpra.exe, Xpra_cmd.exe and Xpra-Launcher.exe. So if the users somehow finds his way to one of the other EXE files (ie: Encoding_info.exe, GStreamer_info.exe...) they will still get the error/warning, we will have to assume they are clever enough to figure it out from there.

[Smo]

I can help do this. Just not sure where to place psvince.dll.

[Antoine Martin]

Oops, it's already done, the changeset for this is r5362.

[J. Max Mena]

Retested with r5828, uninstaller shows a pop-up that tells the user they must stop Xpra before uninstalling.

[Antoine Martin]

Done!

PS: caused #560

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/495