xpra icon
Bug tracker and wiki

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#499 closed defect (fixed)

old servers error out with 0.11.x clients

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 0.12
Component: core Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

The problem comes from the newer bencoders, which do not send dictionary keys in a specific order (pointless since python will immediately stick them in a dict which loses the order), solutions:

  • restore dict order (yuk)
  • apply patch attached to old branches (which will not be applied by distros since they're stuck on broken versions...)

The error shows up in the server log as:

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/protocol.py", line 575, in do_read_parse_thread_loop
  File "/usr/lib64/python2.7/site-packages/xpra/bencode.py", line 72, in bdecode
  File "/usr/lib64/python2.7/site-packages/xpra/bencode.py", line 45, in decode_list
  File "/usr/lib64/python2.7/site-packages/xpra/bencode.py", line 55, in decode_dict
ValueError
connection lost: gibberish received: 'l5:hellod16:...

Attachments (1)

bencode.patch (480 bytes) - added by Antoine Martin 6 years ago.
this fixes the old servers

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by Antoine Martin

Attachment: bencode.patch added

this fixes the old servers

comment:1 Changed 6 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

r5236 restores compatibility with old servers, backport for v0.11.x branch in r5239

Note: if you've come here because you are seeing this error, this means you are using an old, buggy and unsupported server...

Last edited 6 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 6 years ago by Antoine Martin

Description: modified (diff)
Note: See TracTickets for help on using tickets.