xpra icon
Bug tracker and wiki

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#524 closed defect (invalid)

libav10 compatibility FTBFS

Reported by: onlyjob Owned by: Antoine Martin
Priority: major Milestone: 0.12
Component: core Version: 0.11.x
Keywords: Cc:

Description

As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=739459
some changes are to be made for libav10 compatibility.

Migration documentation can be found at
https://wiki.libav.org/Migration/10

Please review the attached patch that fixes build-time errors. It is not tested at run-time yet.

Attachments (1)

libav10.patch (4.4 KB) - added by onlyjob 6 years ago.
proposed patch

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by onlyjob

Attachment: libav10.patch added

proposed patch

comment:1 Changed 6 years ago by onlyjob

Tested with libav9 -- all good. Builds fine and works well.

comment:2 Changed 6 years ago by Antoine Martin

Resolution: invalid
Status: newclosed

We already use those constants for ffmpeg v2 onwards in dec_avcodec2, see here: xpra.codecs.dec_avcodec2.decoder. Unfortunately, last time I checked it built OK but did not work properly with libav (runtime crashes).


This patch would break dec_avcodec builds for many distributions, including from a quick grep:

  • Ubuntu Precise
  • Ubuntu Quantal
  • Ubuntu Saucy
  • Debian Wheezy

Whilst only improving the situation on:

  • Debian Jessie
  • Debian Sid
  • Ubuntu Trusty


So I am closing this as invalid, and will apply the patch at build time only.


FYI: dec_avcodec is in maintenance mode, and new work is only added to dec_avcodec2 (h265 support, etc..)

comment:3 Changed 6 years ago by Antoine Martin

FYI: here are some better patches:


Note: for every release, I waste a few hours dealing with libav patching. Tiresome.

That burden is multiplied by the number of projects that link against it. Mind boggling.

comment:4 Changed 6 years ago by Antoine Martin

Milestone: 0.130.12

re-assigning to correct milestone

Note: See TracTickets for help on using tickets.