compile error in enc_x265

[Opsomer]

Error compiling Cython file:
------------------------------------------------------------
...
    assert colorspace in COLORSPACES, "invalid colorspace: %s (must be one of %s)" % (colorspace, COLORSPACES.keys())
    #ratings: quality, speed, setup cost, cpu cost, gpu cost, latency, max_w, max_h, max_pixels
    #we can handle high quality and any speed
    #setup cost is moderate (about 10ms)
    return video_codec_spec(encoding=encoding, output_colorspaces=COLORSPACES[colorspace],
                      Encoder, codec_type=get_type(),
                            ^
------------------------------------------------------------

xpra/codecs/enc_x265/encoder.pyx:242:29: Non-keyword arg following keyword arg
Traceback (most recent call last):
  File "setup.py", line 1620, in <module>
    setup_options["ext_modules"] = cythonize(ext_modules, gdb_debug=False)
  File "/usr/lib/python2.7/site-packages/Cython/Build/Dependencies.py", line 785, in cythonize
    cythonize_one(*args[1:])
  File "/usr/lib/python2.7/site-packages/Cython/Build/Dependencies.py", line 902, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: xpra/codecs/enc_x265/encoder.pyx
==> ERROR: A failure occurred in build().
    Aborting...

should it be

codec_class=Encoder,

[Antoine Martin]

Yes, you're right I think.

It should be fixed in r6606. Let me know and I'll backport the fix.

Note: no-one should be using enc_x265 at this point because it is ridiculously slow, which is why it doesn't really get tested very often, and not even compile-tested since it isn't packaged for any of the major distros AFAIK.

[Antoine Martin]

Not heard back - closing.

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/587