xpra icon
Bug tracker and wiki

Opened 9 years ago

Closed 7 years ago

Last modified 6 years ago

#59 closed enhancement (fixed)

bindings cleanup: move it, split it, import side effects, etc

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: minor Milestone: 0.10
Component: client Version:
Keywords: Cc:

Description (last modified by Antoine Martin)

  • we now import it from the xposix platform code and that has side effects (registers its own event loop filter)
  • it is getting too big (almost 2000 lines)
  • 2 methods live in lowlevel/__init__.py but the rest lives in bindings..

time to do something about it

Attachments (2)

xpra-splitxkb.patch (7.7 KB) - added by Antoine Martin 9 years ago.
split some xkb stuff used in xpra/xposix
xpra-splitxkb-build.patch (2.6 KB) - added by Antoine Martin 9 years ago.
patch for the build files

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by Antoine Martin

Attachment: xpra-splitxkb.patch added

split some xkb stuff used in xpra/xposix

comment:1 Changed 9 years ago by Antoine Martin

Description: modified (diff)
Owner: changed from Antoine Martin to Antoine Martin
Status: newaccepted

The patch above duplicates the xkb stuff so we can import xposix/gui without needing anything from wimpiggy/lowlevel, unfortunately:

  • xclipboard, xsettings and xroot_props still import other bits
  • it duplicates code rather than split it into a library portion

So, not going to be merged as is...

Changed 9 years ago by Antoine Martin

Attachment: xpra-splitxkb-build.patch added

patch for the build files

comment:2 Changed 9 years ago by Antoine Martin

Component: serverclient
Milestone: current0.1
Priority: majorminor
Type: defectenhancement

r470 allows us to avoid the x11 event loop pollution from the client code.

It would still be preferable to split the bindings.so library so as to minimize the amount of code we load into the client process (800KB is quite a lot) so not closing this ticket yet.

comment:3 Changed 9 years ago by Antoine Martin

Version: 0.1.0

comment:4 Changed 9 years ago by Antoine Martin

Version: 0.1.00.0.7.35

comment:5 Changed 8 years ago by Antoine Martin

Milestone: 0.1future

Not a big priority since the major problem (x11 event loop pollution) is solved.

comment:6 Changed 7 years ago by Antoine Martin

Status: acceptednew

Mostly done in 0.10 by splitting the large gtk/X11 bindings into pure-X11 bindings and gtk bindings (see r3248 and many fixes after that).
This makes it a lot easier to switch away from gtk - even for the server components, should we want to do that.


This will do for now.

comment:7 Changed 7 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

comment:8 Changed 6 years ago by Antoine Martin

Milestone: future0.10
Version: 0.0.7.35

(setting correct milestone the work was completed in)

Note: See TracTickets for help on using tickets.