#59 closed enhancement (fixed)
bindings cleanup: move it, split it, import side effects, etc
Reported by: | Antoine Martin | Owned by: | Antoine Martin |
---|---|---|---|
Priority: | minor | Milestone: | 0.10 |
Component: | client | Version: | |
Keywords: | Cc: |
Description (last modified by )
- we now import it from the xposix platform code and that has side effects (registers its own event loop filter)
- it is getting too big (almost 2000 lines)
- 2 methods live in
lowlevel/__init__.py
but the rest lives in bindings..
time to do something about it
Attachments (2)
Change History (11)
Changed 10 years ago by
Attachment: | xpra-splitxkb.patch added |
---|
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Owner: | changed from Antoine Martin to Antoine Martin |
Status: | new → accepted |
The patch above duplicates the xkb stuff so we can import xposix/gui
without needing anything from wimpiggy/lowlevel
, unfortunately:
xclipboard
,xsettings
andxroot_props
still import other bits- it duplicates code rather than split it into a library portion
So, not going to be merged as is...
comment:2 Changed 10 years ago by
Component: | server → client |
---|---|
Milestone: | current → 0.1 |
Priority: | major → minor |
Type: | defect → enhancement |
r470 allows us to avoid the x11 event loop pollution from the client code.
It would still be preferable to split the bindings.so
library so as to minimize the amount of code we load into the client process (800KB is quite a lot) so not closing this ticket yet.
comment:3 Changed 10 years ago by
Version: | → 0.1.0 |
---|
comment:4 Changed 10 years ago by
Version: | 0.1.0 → 0.0.7.35 |
---|
comment:5 Changed 10 years ago by
Milestone: | 0.1 → future |
---|
Not a big priority since the major problem (x11 event loop pollution) is solved.
comment:6 Changed 9 years ago by
Status: | accepted → new |
---|
Mostly done in 0.10 by splitting the large gtk/X11 bindings into pure-X11 bindings and gtk bindings (see r3248 and many fixes after that).
This makes it a lot easier to switch away from gtk - even for the server components, should we want to do that.
This will do for now.
comment:7 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:8 Changed 8 years ago by
Milestone: | future → 0.10 |
---|---|
Version: | 0.0.7.35 |
(setting correct milestone the work was completed in)
comment:9 Changed 17 months ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/59
split some xkb stuff used in xpra/xposix