xpra icon
Bug tracker and wiki

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#658 closed defect (fixed)

Xpra Proxy no longer working with 0.14.2

Reported by: sschnitzer Owned by: sschnitzer
Priority: critical Milestone:
Component: server Version: 0.14.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Hello,

running "xpra proxy", "xpra start" (both CentOS 7), and "xpra attach" (on Win7), I was able to connect using version 0.13.8.
However, using the same setup with 0.14.2, the server gives me the following error:

2014-08-22 22:20:00,850 invalid_header(Protocol(SocketConnection(('127.0.0.1', 31001) - ('127.0.0.1', 59099))), "hello: {'named_cursors': 1, 'pango.version': '1.29.4', 'xkbmap_layout': 'de', 'proxy.python.full_ver"...)
2014-08-22 22:20:00,850 will process ui packet gibberish
2014-08-22 22:20:00,850 Received uninterpretable nonsense from Protocol(SocketConnection(('127.0.0.1', 31001) - ('127.0.0.1', 59099))): invalid packet format, not an xpra client?
2014-08-22 22:20:00,850  data: "hello: {'named_cursors': 1, 'pango.version': '1.29.4', 'xkbmap_layout': 'de', 'proxy.python.full_ver"...
2014-08-22 22:20:00,851 Disconnecting client Protocol(SocketConnection(('127.0.0.1', 31001) - ('127.0.0.1', 59099))): invalid packet format, not an xpra client?

From what I got until now, the server fails in xpra/net/protocol.py in the line "if read_buffer[0] not in ("P", ord("P")):"
If a client connects directly (i.e., without proxy), a prefix of 8 Bytes is sent which begins with a "P" (0x50) character. However, the proxy does not seem to forward these 8 bytes. The server then checks if the first byte is a "P". However, it is an "h" (from "hello:...") and therefore fails.

Thanks in advance for any help!
Stephan

Change History (3)

comment:1 Changed 5 years ago by Antoine Martin

Description: modified (diff)
Owner: changed from Antoine Martin to sschnitzer
Priority: majorcritical

Sorry about that, r7420 should fix this. (r7421 is also worth having)

Does that work for you?

Will backport both to v0.14.x and make a new release.

comment:2 Changed 5 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Backport to v0.14.x in r7422, feel free to re-open if I've missed anything.

comment:3 Changed 5 years ago by sschnitzer

It works after I applied both, r7420 and r7421.
Thanks!

Note: See TracTickets for help on using tickets.