#671 closed defect (fixed)
Server crashes if lz4 is missing
Reported by: | sschnitzer | Owned by: | sschnitzer |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | server | Version: | 0.14.x |
Keywords: | Cc: |
Description
Hi.
If the server does not have lz4 installed, connecting to the server via proxy fails. The proxy log gives the following error message:
2014-09-05 16:51:31,629 internal error: error in network packet reading/parsing Traceback (most recent call last): File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 587, in _read_parse_thread_loop self.do_read_parse_thread_loop() File "/usr/lib64/python2.7/site-packages/xpra/net/protocol.py", line 762, in do_read_parse_thread_loop self._process_packet_cb(self, packet) File "/usr/lib64/python2.7/site-packages/xpra/server/proxy_instance_process.py", line 526, in process_server_packet packet[8] = compressed_wrapper("cursor", pixels, zlib=zlib, lz4=lz4, lzo=lzo, can_inline=False) File "/usr/lib64/python2.7/site-packages/xpra/net/compression.py", line 184, in compressed_wrapper assert use_lz4, "cannot use lz4" AssertionError: cannot use lz4
This immediately terminates the connection.
I guess the server should either negotiate with the client not to use lz4 or lz4 should be considered mandatory in "setup.py".
Error is reproducable with 0.14.4 (Windows client, Linux proxy+server).
Kind regards,
Stephan
Change History (4)
comment:1 Changed 6 years ago by
Owner: | changed from Antoine Martin to sschnitzer |
---|
comment:3 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Backport in r7524.
Forgot to mention that you really should have lz4 installed... (lzo at the very least)
comment:4 Changed 4 days ago by
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/671
Note: See
TracTickets for help on using
tickets.
Oops sorry!
Does r7521 fix things for you? (there was a big FIXME note near that code...)