Xpra: Ticket #672: wrong color mapping of application window icons with plain rgb encoding (png disabled)

Hi.

The application icons (displayed in the task bar and on the top left of windows) have wrong color mapping if compression is disabled. The attached file shows the top left corner of a "konqueror" window. The left part depicts the icon of a xpra-redirect window, the right part of a native one. I guess that the red and blue channels got accidentially swapped. My setup: Xpra 0.14.4 Linux server, Windows 7 client. Client xpra.conf (only altered options):

encodings = rgb
compressors = none

Without these options, the window icons are correct.

Best, Stephan

Fri, 05 Sep 2014 16:48:06 GMT - sschnitzer: attachment set

attachment set to xpra_icons.png

konqueror application icons (wrong and correct side-by-side)

Wed, 10 Sep 2014 11:21:58 GMT - Antoine Martin: owner changed

owner changed from Antoine Martin to sschnitzer

I've added a test system tray with clear red, green and blue colours to make it easier to test in r7550.

I am unable to reproduce this bug. Can you be a bit more specific about which "Linux Server" you have used?

Are you sure that compressors = none makes any difference? (try -z 1 on command line to override your config)

Wed, 10 Sep 2014 17:13:05 GMT - sschnitzer:

The system tray works fine, your test program produces the same result with and without xpra.

Hover, the actual problem is the icon displayed on the top left of windows. The correct term seems to be "title bar", here is picture: http://en.wikipedia.org/wiki/Title_bar The same icon is used for the the "task bar": http://en.wikipedia.org/wiki/Taskbar

You are right, that compressors does not matter. I just verified: encodings = rgb (wrong colors) encodings = all (correct colors)

Server is Centos 7 having the respective rpm packages from the xpra.org download directory installed.

Thu, 11 Sep 2014 14:13:25 GMT - Antoine Martin: owner changed

owner changed from sschnitzer to totaamsschnitzer

Sorry about that, your description was perfectly clear but I somehow managed to get confused about what I was doing!

r7576 fixes this (will backport to v0.14.x) and r7577 adds a simple test application which makes it easy to see what is going on (same code as the tray app)

I think this bug is very old, but we never noticed because until now png was always available and was used ahead of rgb for window icons.

Does this work for you? Can I close?

Thu, 11 Sep 2014 14:13:51 GMT - Antoine Martin: owner changed

owner changed from totaamsschnitzer to sschnitzer

Thu, 11 Sep 2014 14:14:56 GMT - Antoine Martin: summary changed

summary changed from Wrong color mapping of application icons if compression disabled to wrong color mapping of application window icons with plain rgb encoding (png disabled)

(edit title)

Thu, 11 Sep 2014 16:36:35 GMT - sschnitzer:

I applied r7576 to the xpra server code, only. Right? Unfortunately, this did not solve the issue. I attach a screenshot of r7577.

Thu, 11 Sep 2014 16:37:21 GMT - sschnitzer: attachment set

attachment set to xpra_test.png

Screenshot of test_window_icon_colors.py

Thu, 11 Sep 2014 16:42:37 GMT - Antoine Martin:

No, r7576 is a client-side fix, you can find a beta win32 build with the fix here: http://xpra.org/beta/.

Thu, 11 Sep 2014 17:29:46 GMT - sschnitzer:

Thanks for the extra win32 build. Problem solved!

Fri, 12 Sep 2014 02:20:50 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed
resolution set to fixed

Backport to v0.14.x in r7579. (non-trivial)

Closing.

Sat, 23 Jan 2021 05:02:34 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/672