xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#818 closed defect (fixed)

14.20 Xpra builds have no spinners

Reported by: J. Max Mena Owned by: J. Max Mena
Priority: minor Milestone: 0.14
Component: client Version: 0.14.x
Keywords: Cc:

Description

Tested builds from xpra.org/beta and xpra.org/dists:

  • Windows r8634 14.20
  • CentOS 6.4 20150219 build
  • OSX r8600 14.19

Against a Fedora 20 20150219 14.20 build gotten from xpra.org/beta

And I'm not seeing any spinners upon network disconnect(unplugged ethernet cable). I do, however, see the print indicating that I should be seeing spinners.

Change History (10)

comment:1 Changed 4 years ago by J. Max Mena

Component: androidclient
Version: trunk0.14.x

comment:2 Changed 4 years ago by Antoine Martin

Milestone: 0.14
Owner: changed from Antoine Martin to J. Max Mena

This is fixed in r8708.
(the 0.15 branch removed the window-type normalization code which was causing this problem)

FYI: you can trigger the spinners just by running the client with:

XPRA_FAKE_BROKEN_CONNECTION=1 xpra attach ...

Easier than messing with network cables / connections!

If you find problems with the spinners, please always include opengl info and try turning that on or off. The paint window code is very different for each case.

comment:3 Changed 4 years ago by J. Max Mena

Retested with an r8743 OSX, the 20150227 CentOS 6.4, and an r8743 Windows client against an r8743 Fedora 20 server:

  • I see spinners on everything except OSX WITH OpenGL


I should mention that I was seeing no spinners with and without OpenGL. I thought I included that in the original description but I must have missed it.

comment:4 Changed 4 years ago by Antoine Martin

Owner: changed from J. Max Mena to Antoine Martin
Status: newassigned

(OK thanks, will test when I get a chance - my 10.5.x VM does not have opengl)

comment:5 Changed 4 years ago by Antoine Martin

Priority: majorminor

Just tested on a 10.6 VM and the spinners work with the 0.15 beta builds, just not with the latest 0.14.21..

(lowering the priority as the focus is now on 0.15)

comment:6 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

r9167 backports the painting of the spinners using opengl.
It makes sense to apply this because mixing opengl and cairo on the same window is not guaranteed to work and could even cause problems (and not just missing spinners - could be responsible for #646 for example).

Tested on Linux (Fedora), XP, and OSX 10.6 using: XPRA_FAKE_BROKEN_CONNECTION=1
I have uploaded beta 0.14.23 builds for osx and win32.

@maxmylyn: does this work for you? If so, please close the ticket.
It is worth briefly checking that this change does not interfere with opengl painting, be it video regions, normal paints, or even the window border option (ie: border=blue,5)

comment:7 Changed 4 years ago by J. Max Mena

Tested OSX build:

  • Spinners work as expected with and without opengl enabled

I'm also unable to locate the beta win32 build /beta.

comment:8 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Closing.

Beta 0.14.23 for win32 were missing - sorry!

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:9 Changed 4 years ago by Antoine Martin

Important fix for opengl spinners in r9271 (+backport for v0.14.x and v0.15.x in r9272)

Another potential fix for xpra 0.14.23 - Spinners not going away in r9265.

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:10 Changed 4 years ago by Antoine Martin

I think it is quite possible that previous bugs were causing the crashes on win32 and osx, so r9291 tries to re-enable opengl by default on all platforms. We'll see how it goes.

Note: See TracTickets for help on using tickets.