xpra icon
Bug tracker and wiki

Opened 9 years ago

Closed 9 years ago

Last modified 32 hours ago

#82 closed enhancement (fixed)

r558: build modifies a file which is in SVN: src/xpra/build_info.py

Reported by: Timo Juhani Lindfors Owned by: Antoine Martin
Priority: major Milestone: 0.1
Component: core Version: 0.1.0
Keywords: Cc:

Description

Subject should say it all. Please keep original source code files in SVN and keep files that are generated during build outside SVN. This ensure that "svn diff" does not show bogus changes.

(This also causes issues for me when I use git svn and git-buildpackage.)

Change History (3)

comment:1 Changed 9 years ago by Antoine Martin

Component: android → core
Milestone: current → 0.1
Status: new → accepted
Type: defect → enhancement

TODO:

  • delete the file
  • add it to svn:ignore
  • verify that all scripts (make-src-snapshot, build scripts, etc) either re-create it or don't require it
  • test thoroughly on OSX and win32, make a beta build on buildbot

comment:2 Changed 9 years ago by Antoine Martin

Resolution: → fixed
Status: accepted → closed

r560 does this, win32 tested ok and OSX uses a posix-like build so should be fine (tm)

comment:3 Changed 32 hours ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/82

Note: See TracTickets for help on using tickets.