xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 7 years ago

Closed 5 years ago

Last modified 17 months ago

#847 closed task (fixed)

more automated tests

Reported by: Antoine Martin Owned by: Smo
Priority: critical Milestone: 2.0
Component: tests Version: trunk
Keywords: Cc:

Description (last modified by Antoine Martin)

Follow up from #177, see also #660 - in particular things like #822.

  • integration tests: we want some tests that start a server and connect to it.

Shadow server, normal server, proxy, etc... Even the tcp proxy can be exercised this way.
Concurrent connections (spawn 10 xpra info?), etc.

Here's a tricky one that I would like to be able to catch with some tests, but it is going to be HARD: r8604 broke nvenc4 + nvenc5 with the proxy server only (fixed by r9413 + backport in r9414).

  • client rendering tests: we should be able to fire up a virtual display, create a window (try both pixmap and opengl backends) and paint on it (no client class involved), then check that no errors or exceptions were triggered.
  • this one would be hard to check for: #867

Change History (13)

comment:1 Changed 7 years ago by Antoine Martin

Milestone: 0.15 → 0.16
Status: new → assigned

(fix milestone - too late for 0.15)

comment:2 Changed 7 years ago by Antoine Martin

Description: modified (diff)

comment:3 Changed 7 years ago by Antoine Martin

Description: modified (diff)
Summary: add some client-server integration tests → more automated tests

comment:4 Changed 7 years ago by Antoine Martin

Description: modified (diff)

comment:5 Changed 7 years ago by Antoine Martin

I don't see how this can easily be automated, but it would be nice to catch bugs like #926 automatically.

comment:6 Changed 7 years ago by Antoine Martin

Milestone: 0.16 → 0.17
Priority: major → critical

And also catch things like: #1031

comment:7 Changed 6 years ago by Antoine Martin

Milestone: 0.17 → 1.0

comment:8 Changed 6 years ago by Antoine Martin

Milestone: 1.0 → 1.1

Milestone renamed

comment:9 Changed 6 years ago by Antoine Martin

Milestone: 1.1 → 2.0

Milestone renamed

comment:10 Changed 5 years ago by Antoine Martin

Owner: changed from Antoine Martin to Smo
Status: assigned → new

As of r14869 + r14868 + r14867 + r14866, the unit tests have been improved, most run with both python2 and python3 and we now also run the tests as part of the build process for win32 (r14870) and osx (r14871)!

@smo: FYI, feel free to just close.

comment:11 Changed 5 years ago by Smo

Resolution: → fixed
Status: new → closed

comment:12 Changed 5 years ago by Antoine Martin

For reference, the latest run scripts allow us to pass a specific unit test to run (useful for debugging), and the following environment variables are also useful:

DELETE_TEMP_FILES=0 \
XPRA_ALL_DEBUG=1 \
XPRA_TEST_DEBUG=1 \
    ./run2 ./unit/server/server_sockets_test.py

comment:13 Changed 17 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/847

Note: See TracTickets for help on using tickets.