xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#859 closed defect (fixed)

Remote browser commands don't work in Chrome HTML 5 viewer

Reported by: J. Max Mena Owned by: J. Max Mena
Priority: trivial Milestone: 1.0
Component: html5 Version: trunk
Keywords: Cc:

Description

I suspect the wording will get a bit confusing.


Using the HTML 5 Viewer with Firefox on Windows and Ubuntu against a Fedora 21 server running trunk r9357:

Issuing commands to Firefox running remotely such as ctrl + t and ctrl + w work in Windows and Ubuntu, but do not work with Google Chrome in Windows and Ubuntu. If I attempt to use these commands then they are directed to Google Chrome running locally, rather than Firefox on the remove machine.


However, OSX isn't an issue at the moment as the Control and Command keys haven't been swapped yet(those pesky OSX users...) so ctrl + t will open a tab on the remote Firefox and cmd + t will open a tab locally in Safari and Google Chrome. Firefox, however indicates that you gave it a command(cmd + t) to open or close a tab but doesn't actually open or close a tab.


I have a feeling it may be an issue on other platforms(Fedora, Debian, Arch, etc), but my Cent6.4 machine is too old to run Google Chrome, and I haven't gotten Fedora working with our new test-bench environment.


As an aside, I'm not sure if there is a way around it depending on how Google Chrome handles the Control key.

Change History (9)

comment:1 Changed 3 years ago by Antoine Martin

Owner: changed from Josh to J. Max Mena

@maxmylyn: is this still a problem?

comment:2 Changed 3 years ago by Antoine Martin

Milestone: 0.160.17

comment:3 Changed 3 years ago by J. Max Mena

Owner: changed from J. Max Mena to Antoine Martin

Just accidentally tested it trying to get to this ticket. Yes, it is still a problem, at least as of r12379 (trunk, Fedora 23 server).

Of note: Still works as expected with Firefox. (both browsers in Windows)

comment:4 Changed 3 years ago by Antoine Martin

Milestone: 0.170.18
Status: newassigned

Re-scheduling.

comment:5 Changed 3 years ago by Antoine Martin

For some key combinations we can use preventDefault() to ensure the browser doesn't intercept the key event (but we still have to inject it into our key event handling code I think), but for some others it's just not possible: javascript capture browser shortcuts (ctrl+t/n/w): These combinations cannot get captured by Javascript, but embed plugins can capture these.
So for these, we would need a plugin.

comment:6 Changed 3 years ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

See comment:5, as of r12793 we now intercept as much as we can so things like control-S will save the file in gedit rather than triggering the save page action of the browser.

Doing more than that would require a browser plugin...

comment:7 Changed 3 years ago by J. Max Mena

Resolution: fixed
Status: newclosed

Excellent! Firefox is now usable....within Firefox.

Closing.

comment:8 Changed 3 years ago by J. Max Mena

Quick note to anyone who didn't read the links in comment:5

  • These shortcuts will not work in Chrome due to a Google design decision
  • However they will work in OSX because the cmd and ctrl keys haven't been swapped. Not sure if that's a bug or not, just noting it.

comment:9 Changed 3 years ago by Antoine Martin

Milestone: 0.181.0

Milestone renamed

Note: See TracTickets for help on using tickets.