xpra icon
Bug tracker and wiki

Opened 5 years ago

Closed 5 years ago

#874 closed defect (fixed)

don't send pixels for iconified windows

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: blocker Milestone: 0.16
Component: core Version: 0.15.x
Keywords: Cc:

Description

This was not a problem before, because we used to unmap the windows.
But now that we use the proper iconified state, the window is still mapped and we still get damage events.
There is nothing wrong with sending window updates, that's how the window managers can show a window preview in the taskbar for example, but we shouldn't be doing it at full speed.
I have a patch which re-uses the go_idle / no_idle methods - but it isn't 100% safe: if the source was idle, we can end up resuming a window-source that is still iconified.

Attachments (1)

throttle-iconified-windows.patch (1.3 KB) - added by Antoine Martin 5 years ago.
this works - just needs guarding against no_idle called when still iconified

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by Antoine Martin

this works - just needs guarding against no_idle called when still iconified

comment:1 Changed 5 years ago by Antoine Martin

Status: newassigned

r9542 does this - will backport.

I have also spotted some issues with wm-state updates: "iconic" is an attribute of WindowModel but we handle state changes in the superclass.. which can cause errors.

comment:2 Changed 5 years ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

"iconic" fixes:

  • in trunk, the whole window message handler function has now been moved since OR and tray windows should not be processing those messages anyway: r9545 (fairly big change)
  • in 0.15: we only filter out the change to IconicState for OR windows (safer)
Note: See TracTickets for help on using tickets.