Xpra: Ticket #879: Typo in gtk_common/quit.py version 0.14.24 r9443

It seems there is a typo in the file xpra/gtk_common/quit.py line 74, global __oldhook. When I use --exit-with-children option to start the server and everything exits, Xpra throws an error with "_oldhook used before initialized" at line 75 or something, and the X Server xpra started is not killed and left running. I checked the "trunk" of subversion, and the same file writes global _oldhook on this line. So I changed line 74 of quit.py of 0.14.24 to global _oldhook and it works.

Tue, 02 Jun 2015 08:13:20 GMT - Antoine Martin: status changed; resolution set

status changed from new to closed
resolution set to fixed

Thanks! Applied in r9568.

(I remember clearly fixing this same bug in trunk / 0.15, I must have somehow applied it wrong to the v0.14.x branch)

Wed, 16 Dec 2015 03:19:08 GMT - Antoine Martin: summary changed

summary changed from Typo in gtk_common/quit.py version 0.14.24(subversion 9443) to Typo in gtk_common/quit.py version 0.14.24 r9443

(just editing title)

Sat, 23 Jan 2021 05:08:39 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/879