#879 closed defect (fixed)
Typo in gtk_common/quit.py version 0.14.24 r9443
| Reported by: | duanbw | Owned by: | Antoine Martin |
|---|---|---|---|
| Priority: | major | Milestone: | 0.16 |
| Component: | server | Version: | 0.14.x |
| Keywords: | Cc: |
Description
It seems there is a typo in the file xpra/gtk_common/quit.py line 74, global __oldhook. When I use --exit-with-children option to start the server and everything exits, Xpra throws an error with "_oldhook used before initialized" at line 75 or something, and the X Server xpra started is not killed and left running. I checked the "trunk" of subversion, and the same file writes global _oldhook on this line. So I changed line 74 of quit.py of 0.14.24 to global _oldhook and it works.
Change History (2)
comment:1 Changed 4 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 4 years ago by
| Summary: | Typo in gtk_common/quit.py version 0.14.24(subversion 9443) → Typo in gtk_common/quit.py version 0.14.24 r9443 |
|---|
(just editing title)
Note: See
TracTickets for help on using
tickets.
copyleft 2010 - 2018
Thanks! Applied in r9568.
(I remember clearly fixing this same bug in trunk / 0.15, I must have somehow applied it wrong to the v0.14.x branch)