xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

#886 closed defect (fixed)

OSX GUI won't connect (password box issue)

Reported by: rnc01 Owned by: rnc01
Priority: critical Milestone: 0.16
Component: client Version: 0.15.x
Keywords: Cc:

Description

In trying to connect to a FreeBSD server with the OSX client (both the one on the main page and the r9554 development build)...

If I launch the client manually via a terminal window, it works/connects fine.

If I try to fill in the connection info in the GUI, it connects fine assuming I leave the password box blank and the password prompt appears in a terminal window.

If I try to launch the client via the GUI from /Applications no matter what I try the connection fails.

As you can see from the screenshots this appears to be an issue with the authentication method?

Attachments (2)

Screen Shot 2015-06-08 at 7.34.21 PM.png (211.0 KB) - added by rnc01 4 years ago.
Screen Shot 2015-06-08 at 7.33.33 PM.png (154.9 KB) - added by rnc01 4 years ago.

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by rnc01

Changed 4 years ago by rnc01

comment:1 Changed 4 years ago by rnc01

The first screenshot is a SSH connection by leaving the password box blank, launching the GUI by /Applications/Xpra.app/Contents/MacOS/Xpra_Launcher

The second screenshot is an attempt to fill the password into the password box in the GUI, also launching the GUI by /Applications/Xpra.app/Contents/MacOS/Xpra_Launcher

Last edited 4 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 4 years ago by Antoine Martin

Component: androidclient
Priority: majorcritical
Status: newassigned

Ah, it looks like we do a double authentication attempt: the password is handed over to ssh (via an ugly askpass hack) and then also to the remote end.
The server then bounces the connection because no authentication is required.

Will fix.

comment:3 Changed 4 years ago by Antoine Martin

Owner: changed from Antoine Martin to rnc01
Status: assignednew

r9640 changes the disconnection to a simple warning, backports to v0.14.x and v0.15.x in r9641.

I had tried to do something more complicated to try to ensure we only pass the password once (either to ssh or in the hello packet but never both), but the code got messy - and this is still safe.

@rnc01: does that work for you?

comment:4 Changed 4 years ago by rnc01

I'll give it a shot and let you know but will be a few days, I'm out of town and the machines in question are firewalled to local traffic only.

comment:5 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Not heard back, I assume this is fixed - feel free to re-open if that's not the case.

The change was included in 0.14.26 and 0.15.1

Note: See TracTickets for help on using tickets.