xpra icon
Bug tracker and wiki

Opened 22 months ago

Closed 4 months ago

#890 closed enhancement (fixed)

minified (non-free) javascripts in source

Reported by: onlyjob Owned by: Antoine Martin
Priority: major Milestone: 1.0
Component: html5 Version: 0.15.x
Keywords: Cc:

Description

"html5" folder contains minified javascript (.js) and .css files that are effectively the same as pre-compiled binaries -- un-readable, non-modifiable and non-distributable in Debian.

Files in "tests/xpra/js" also contain obfuscated (minified) portions.

It is the best to avoid having minified files in source tree.

Please replace all minified files with original uncompressed ones.

Change History (8)

comment:1 Changed 22 months ago by Antoine Martin

Milestone: 0.161.0
Type: defectenhancement

Not a high priority and I can't seem to find how to do this from jhbuild or rpmbuild anyway.

comment:2 in reply to:  1 Changed 14 months ago by jonathan.underwood

Replying to antoine:

Not a high priority and I can't seem to find how to do this from jhbuild or rpmbuild anyway.

What's "this" in this context? Do you mean you can't work out how to minify a javascript source during rpmbuild? If that's the issue, this reciped might help:

BuildRequires:  python-slimit

....

%build
...

rm -f some.minified.file.js
slimit -m src/some.file.js > ./some.minified.file.js

FWIW, Fedora has similar packaging requirements to Debian in regards to this issue.

Last edited 12 months ago by Antoine Martin (previous) (diff)

comment:3 Changed 14 months ago by onlyjob

Minification is harmful and unnecessary: https://wiki.debian.org/onlyjob/no-minification

comment:4 in reply to:  3 Changed 14 months ago by jonathan.underwood

Replying to onlyjob:

Minification is harmful and unnecessary: https://wiki.debian.org/onlyjob/no-minification

While I have a lot of sympathies with the writer of that page, really it's just a page of opinions with no facts (i.e. benchmarks) to back up any of the the assertions made. Conversely, a quick google search gives various benchmarks showing advtantages of minification, with hard figures. And I say that as someone who would like to see minification practices stopped.

comment:5 Changed 9 months ago by Antoine Martin

Milestone: 1.01.1

Milestone renamed

comment:6 Changed 7 months ago by Antoine Martin

Milestone: 1.12.0

Milestone renamed

comment:7 Changed 5 months ago by Antoine Martin

Milestone: 2.01.0
Owner: changed from Josh to Antoine Martin
Status: newassigned

Mostly complete, see ticket:1341#comment:1.

comment:8 Changed 4 months ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

Complete as of r14438 for JS and r14439 for CSS. Will follow up in #1360.

FWIW: the code generated by emscripten for Broadway is hardly readable. But we can't really build it ourselves so this will have to do.
Those so inclined can package it separately. It isn't even used by default right now either (and maybe we should just not load it at all..)

Note: See TracTickets for help on using tickets.