xpra icon
Bug tracker and wiki

Opened 4 years ago

Closed 4 years ago

Last modified 3 months ago

#930 closed defect (fixed)

don't delete printers we have not added

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 0.16
Component: server Version: 0.15.x
Keywords: printing Cc:

Description

We should detect when the lpadmin command fails and keep track of the printers we have successfully added so that we only remove those during cleanup.

This is an issue because if the same printer is plugged into 2 computers, each may have the same definition and since we don't add a prefix to the forwarded printer name, we will try to add the same name - which fails, but then we end up deleting the printer we did not create.

Change History (3)

comment:1 Changed 4 years ago by Antoine Martin

Status: newassigned

The first hurdle is that the reaper code somehow makes python unaware of the actual returncode from the lpadmin command, r10119 fixes that (should backport too).

r10120 takes care of not registering printers until the lpadmin command returns success (returncode=0).
A bit too big for backports, maybe later. (so keeping the ticket open)

comment:2 Changed 4 years ago by Antoine Martin

Resolution: fixed
Status: assignedclosed

Not backporting it because it is too big, focusing on getting 0.16 finished instead.

Closing.

comment:3 Changed 3 months ago by Antoine Martin

See also #2095

Note: See TracTickets for help on using tickets.