xpra icon
Bug tracker and wiki

Opened 2 years ago

Closed 6 months ago

#935 closed task (fixed)

remove support for old buffers

Reported by: Antoine Martin Owned by: Smo
Priority: critical Milestone: 2.0
Component: core Version: 0.15.x
Keywords: Cc:

Description (last modified by Antoine Martin)

Follow up from #465, see also #1073.
This will mean dropping compatibility with Python versions older than 2.7, which means that the release before it would probably have to be LTS.

Attachments (1)

memoryview-buffer-wrapper.patch (35.5 KB) - added by Antoine Martin 2 years ago.
switch to a wrapper class for memalign memory

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by Antoine Martin

switch to a wrapper class for memalign memory

comment:1 Changed 2 years ago by Antoine Martin

Status: newassigned

The patch above removes lots of ugly code, can help us avoid making copies in some cases and speeds up argb and cyxor by a factor of 2.

And whilst we're at it, we could probably drop support for Python3 versions older than 3.3 so we can assume PyMemoryView_FromMemory is present.

Last edited 2 years ago by Antoine Martin (previous) (diff)

comment:2 Changed 23 months ago by Antoine Martin

Milestone: 0.171.0

Let's make 0.17 and LTS, do this after.

comment:3 Changed 15 months ago by Antoine Martin

Milestone: 1.01.1

Milestone renamed

comment:4 Changed 13 months ago by Antoine Martin

Milestone: 1.12.0

Milestone renamed

comment:5 Changed 9 months ago by Antoine Martin

r14514 removes support for old style buffers

comment:6 Changed 9 months ago by Antoine Martin

Owner: changed from Antoine Martin to Smo
Status: assignednew

The memoryview-buffer-wrapper patch has been merged in r14557.

Potential problems with this:

  • performance? (should be at least as good as before)
  • memory leaks, memory corruption, etc (fun!)

@smo: please run the automated tests and compare with v1.0 so we can make sure we don't have regressions anywhere.

comment:7 Changed 9 months ago by Antoine Martin

Description: modified (diff)
Priority: majorcritical

comment:8 Changed 8 months ago by Antoine Martin

More related changes: r14519 (assume memoryview type is available), r14885: zerocopy in network layer!

comment:9 Changed 6 months ago by Smo

Resolution: fixed
Status: newclosed

These have been in for some time and many automated tests ran with no issues.

Note: See TracTickets for help on using tickets.