xpra icon
Bug tracker and wiki

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#957 closed defect (fixed)

windows installer problem with build_args

Reported by: Smo Owned by: Antoine Martin
Priority: major Milestone: 0.16
Component: packaging Version: 0.15.x
Keywords: Cc:

Description

The windows installer batch file MAKE-INSTALLER.BAT doesn't use the build arguments variable BUILD_ARGS during the build_ext phase

Attachments (1)

make-installer.patch​ (676 bytes) - added by Smo 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Smo

Attachment: make-installer.patch​ added

comment:1 Changed 5 years ago by Smo

Component: android → packaging

comment:2 Changed 5 years ago by Antoine Martin

Resolution: → fixed
Status: new → closed

Applied (modified to also update the info line above) in r10385 and compile tested.

comment:3 Changed 5 years ago by Smo

Thanks I just noticed I forgot to do the same or maybe it was the info line I modified.

Was going to attach another patch but no need.

comment:4 Changed 5 years ago by Smo

Also tested. Can we add this to 0.15.x as well if its not too much trouble.

comment:5 Changed 5 years ago by Antoine Martin

OK, feel free to backport it.

comment:6 Changed 5 years ago by Smo

Okay done in r10389 and tested.

Note: See TracTickets for help on using tickets.