Custom Query (2683 matches)

desktop-file-validate returned the following:

xpra_launcher.desktop: error: value "Network" for string list key "Categories" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Trivial to fix as follows:

-Categories=Network
+Categories=Network;

Thank you.

This is a cleaner solution than copying /usr/bin/Xorg to $HOME/.xpra and removing the setuid bits.

The script checks to see if the file is setuid and launches Xorg with ld-linux, otherwise it start Xorg normally. If this is implemented, the code in setup.py that checks if Xorg is setuid can be removed, which should simplify things a bit.

This works because ld-linux.so.2/ld-linux-x86_64.so.2 does not have the setuid bit set. ld-linux is the one executing Xorg.

It was suggested I try the kernel's no-new-privileges feature (new in linux 3.5). Although this looked like what I wanted,it did not work as expected. Xorg started without an issue, but I was unable to attach to the X session. I tested using 'setpriv --no-new-privilages Xorg' on fedora 20.

I tested this on RHEL6/Fedora20/Arch Linux.

#!/bin/sh
#@PydevCodeAnalysisIgnore

function find_ld_linux {
    arch=$(uname -m)

    if [[ $arch == "x86_64" ]]; then
        if [[ -f /lib64/ld-linux-x86-64.so.2 ]]; then
            LD_LINUX='/lib64/ld-linux-x86-64.so.2'
        fi
    elif [[ $arch = "i686" ]]; then
        if [[ -f /lib/ld-linux.so.2 ]]; then
            LD_LINUX='/lib/ld-linux.so.2'
        fi
    fi

    if [[ ! $LD_LINUX ]]; then
        echo "could not determine ld_linux path, please file an xpra bug"
        exit 1
    fi
}

XORG_BIN=$(which Xorg)

if [[ -u $XORG_BIN ]]; then
    # setuid is set, we need to do magic
    find_ld_linux
    exec "${LD_LINUX}" "${XORG_BIN}" "$@"
else
    # setuid is not set on xorg_bin
    exec "${XORG_BIN}" "$@"
fi