Xpra: Ticket #121: jpegquality should not be stored in protocol.py!

Why is it there? It has nothing to do with the network layer...

I only noticed it because during testing something went wrong and the current connection got dropped, then I got this enlightening stacktrace:

Unhandled error while processing packet from peer
Traceback (most recent call last):
  File "xpra/protocol.py", line 457, in _process_packet
    self._process_packet_cb(self, decoded)
  File "xpra/server.py", line 2072, in process_packet
    handler(self, proto, packet)
  File "xpra/server.py", line 1519, in _process_hello
    self._protocol.jpegquality = capabilities["jpeg"]
AttributeError: 'NoneType' object has no attribute 'jpegquality'

Fri, 04 May 2012 09:33:20 GMT - Antoine Martin: description changed

Fri, 04 May 2012 09:39:00 GMT - ahuillet:

I'm not sure where it should be stored, but we should also rename it because it would be interesting to also use it to carry x264/vpx quality.

Fri, 04 May 2012 12:23:41 GMT - Antoine Martin: status changed; resolution set

clean fix in r787

Sat, 23 Jan 2021 04:46:07 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/121