python3 gtk3 client feature parity

[Antoine Martin]

Split from #1568.

Remaining features missing from the python3 / GTK3 client.
Most of those can be seen in the GTK2 version:

browser/xpra/trunk/src/xpra/client/gtk2/gtk2_window_base.py.

• initial focus bits?
• drag n drop (#1493)
• workspace bits
• pointer overlay

[Antoine Martin]

Crash on MS Windows reported upstream: ​pygi key event handler crash on 64-bit with 'de' keyboard layout.

[Antoine Martin]

Forwarded upstream to gnome bugzilla: ​Crash when accessing the "string" attribute of GdkEventKey on 64bit Windows

[Antoine Martin]

macos issues in ticket:1575#comment:10 : opengl, extended input devices support, and gtk2 notification needs porting (see #1492) since macos notifications are unusable (#1305)

[Antoine Martin]

GTK bug from comment:3 has now been moved to ​https://gitlab.gnome.org/GNOME/pygobject/issues/147

[Antoine Martin]

• r18336: add stub gdk3 bindings so we can use functionality not exposed via the gi bindings
• r18338 + r18344: opengl support for macos (needs a little bit more work to enable by default)

[Antoine Martin]

now 90% complete:

• r18347 + r18348 + r18349: full macos opengl support, including changing GPU on the fly, etc
• r18350 + r18351: "pointer overlay" merged into common GTK2 / GTK3 superclass, tested with win32 shadow server
• r18352: "multi-screen" (untested but low risk)
• r18353: workspace support, tested with: xpra control :DISPLAY workspace WINDOWID WORKSPACE
• r18357: drag-n-drop (big)

Still TODO:

• focus with grabs requires add_event_receiver glue
• win32: max size hint, refactor get_window_handle (duplicated), setting cursors crashes (even a default one!?)
• posix: x11 property watcher, xprops
• macos: mouse wheel handler filter (if still needed)

[Antoine Martin]

General updates:

• r18374 + r18377 + r18378 + r18382 + r18385 + r18386: simplify + cleanup
• r18373 + r18375 + r18383: test improvements
• r18379: raise window
• r18380: notify_startup_complete
• r18381: UI thread lockups detection (still happening with GTK3 on macos..)
• r18790: comtypes bug fixed in r18797 + r18798
• r18854: signal handlers are finally fixed!

win32

• max-size works with gtk3 so no need for our native workaround there
• r18370: get_window_handle refactored
• r18372: workaround cursor crash using pillow to resize

Posix

• r18367 full gdk x11 bindings
• r18384: grabs
• r18387: focus

Still TODO:

• launcher doesn't have "advanced" mode encoding selection
• pointer grabs don't work with GTK3? we should also add an event listener for: ​EventGrabBroken
• opengl rendering context does not work with override-redirect windows on win32 (disabled in r18391), though no errors are reported anywhere..
• macos mouse wheel, see also: ​Gdk.Window.set_support_multidevice - maybe GTK3 can give us per-device events? (will they be normalized?)
• macos fullscreen doesn't work with GTK3?
• macos cmd-q crashes? (see ticket:1766#comment:21)
• macos: after maximize the screen is offset upward (see ticket:1766#comment:26)
• win32: crash with firefox's proxy authentication dialog (when firefox started after connecting only?)

[mviereck]

Is there a possibility to enable the GTK3 client?
I would like to test it on debian, especially in pure Wayland environments without X/Xwayland.
The man page shows option --client-toolkit, but I get an error: xpra initialization error: no such option: --client-toolkit.

(Side note: the man page shows options --keyboard-raw till --sound-source as a block instead of single paragraphs.)

[Antoine Martin]

Is there a possibility to enable the GTK3 client?

Yes, just build xpra with python3.

I would like to test it on debian, especially in pure Wayland environments without X/Xwayland.

There is no packaging for Debian yet, only RPMs for Fedora.

the man page shows options --keyboard-raw till --sound-source as a block instead of single paragraphs

Fixed in r18888, thanks!

[Antoine Martin]

This will do for this release, will follow up in #1818

[Antoine Martin]

win32 crash: #2162

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/1717