xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 9 years ago

Closed 9 years ago

Last modified 5 months ago

#185 closed enhancement (fixed)

Better parsing for --ssh option

Reported by: Mike Owned by: Antoine Martin
Priority: minor Milestone: 0.7
Component: client Version:
Keywords: Cc:

Description

If you use some more sophisticated options for ssh (like ssh -o 'ProxyCommand? socat ...') the simple splitting by split() leads to wrong parsing, because it doesn't deal with nested quotings and the like.

Better would be using split() from shlex package. Please see the attached patch.

Attachments (1)

shlex.patch (694 bytes) - added by Mike 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Mike

Attachment: shlex.patch added

comment:1 Changed 9 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

thanks! applied in r1593

comment:2 Changed 7 years ago by Antoine Martin

Milestone: future0.7
Version: trunk

(setting correct milestone the work was completed in)

comment:3 Changed 5 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/185

Note: See TracTickets for help on using tickets.