xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 3 years ago

Closed 3 years ago

Last modified 4 months ago

#1903 closed defect (fixed)

Incorrect icon paths in Window.js

Reported by: berserker Owned by: berserker
Priority: major Milestone: 2.4
Component: html5 Version: trunk
Keywords: Cc:

Description

I was told that this issue is already fixed mainstream (https://github.com/totaam/xpra-html5/pull/1#issuecomment-402606387), but I still see '../icons/' instead of just 'icons/' in the Trunk:

	                                '<span id="maximize' + String(wid) + '"><img src="../icons/maximize.png" /></span> '+
	                                '<span id="close' + String(wid) + '"><img src="../icons/close.png" /></span> '+

Change History (7)

comment:1 Changed 3 years ago by Antoine Martin

Owner: changed from Antoine Martin to berserker

Sorry, I misread the patch.
We changed to use relative urls to handle non-standard paths.
I don't understand why relative paths would not work here. Can you provide a sample configuration?

comment:2 Changed 3 years ago by Antoine Martin

Milestone: 2.4

comment:3 in reply to:  1 Changed 3 years ago by berserker

Replying to Antoine Martin:

We changed to use relative urls to handle non-standard paths.
I don't understand why relative paths would not work here. Can you provide a sample configuration?

'icons/close.png' is also a relative path, it does not start with /.
I'm trying to run Xpra behind the Jupyter single-user server with its nbserverproxy extension, see https://github.com/jupyterhub/nbserverproxy/issues/35. This is a sample configuration.
Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

Last edited 3 years ago by berserker (previous) (diff)

comment:4 Changed 3 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

That's exactly it.
Thanks for bearing with me, applied in r19846.

comment:5 in reply to:  4 Changed 3 years ago by berserker

Replying to Antoine Martin:

Probably you are thinking that src paths should be relative to js files location, but it looks like the paths are calculated relative to the path of the page that loaded the js files.

That's exactly it.
Thanks for bearing with me, applied in r19846.

When it will appear in the Bionic beta repository?

comment:6 Changed 3 years ago by Antoine Martin

When it will appear in the Bionic beta repository?

Try now.

comment:7 Changed 4 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1903

Note: See TracTickets for help on using tickets.