xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 3 years ago

Closed 3 years ago

Last modified 8 months ago

#1951 closed enhancement (fixed)

video-scaling should be set to auto

Reported by: Antoine Martin Owned by: J. Max Mena
Priority: major Milestone: 2.4
Component: encodings Version: 2.3.x
Keywords: Cc:


We already have speed and quality settings.
Those alone should be enough to drive the amount of video scaling applied.
We can keep the existing heuristics for when video scaling is set to a value.
We may want to expose this via the system tray menu and html5 advanced connection options.

Change History (5)

comment:1 Changed 3 years ago by Antoine Martin

Status: newassigned

New heuristics mostly done in r20366 - see commit message for details.
To revert to the previous behaviour, just use --video-scaling=VALUE instead of video-scaling=auto.

This new code targets 1080p at 25fps, more for "video" content, more for high quality or low speed, and less if quality is low or speed is high.
The details of the calculations can be shown with "-d scaling".

Still TODO:

  • make target configurable? (XX MPixels/s?)
  • take into account fullscreen and maximized flags
  • UI updates
Version 2, edited 3 years ago by Antoine Martin (previous) (next) (diff)

comment:2 Changed 3 years ago by Antoine Martin

Owner: changed from Antoine Martin to J. Max Mena
Status: assignednew

Not going to update the UI (we have too many controls already), and not going to use fullscreen or maximized flags (not sure which way they should favour).

@maxmylyn: FYI, the new heuristics should be easier to use (automatic) and will honour the dynamic quality and speed tuning more accurately.

Somewhat related to #1867, see also #1952.

Last edited 3 years ago by Antoine Martin (previous) (diff)

comment:3 Changed 3 years ago by Antoine Martin

Important fixups in r20520.

comment:4 Changed 3 years ago by J. Max Mena

Resolution: fixed
Status: newclosed

Noted and closing.

comment:5 Changed 8 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1951

Note: See TracTickets for help on using tickets.