Xpra: Ticket #1973: IE11 Support

@Antoine Looks like I'm a little late on this as I think you've covered most of this in r20580 but maybe missing:

Fullscreen request:Added IE11 fullscreen request

startsWith and includes Polyfills My approach was to add a seperate polyfill script so it's easier to remove when IE finally dies. For reference added IE11 compatability



Tue, 02 Oct 2018 05:45:06 GMT - Antoine Martin: owner, description changed

Merged in r20583 + r20584, thanks.

Can you please specify what copyright applies to those polyfills? (should be the same as ECMA6 I guess - looks like a BSD variant?)


Tue, 02 Oct 2018 12:22:32 GMT - Mark Harkin:

Sorry, started here https://github.com/paulmillr/es6-shim (MIT) but it was overkill for a few polyfills so ended up just grabbing them from elsewhere, I've already give myself a slap on the wrists!

Just tested r20584 but I think:

window.console = window.console || {
	  log: function () {}
};

needs to be in index.html otherwise Developer tools needs to be open.


Tue, 02 Oct 2018 12:51:11 GMT - Antoine Martin:

needs to be in index.html otherwise Developer tools needs to be open.

No idea where that needs to go, I've tried a few obvious places and none helped. (and since having the developer console open "fixes" things, catch 22)


Tue, 02 Oct 2018 13:09:09 GMT - Mark Harkin:

Sorry my mistake I should have tidied up before submitting the change:

What's missing is actually (1st diff from https://github.com/mjharkin/Xpra/commit/5904fe329d9b1f11acffd65435ddd49ed2406f32 ) This could equally be added to es6-shim.js instead of index.html, depends on your preference.

var console = console || { log: function(){} };

The following should be removed from es6-shim.js

window.console = window.console || {
	  log: function () {}
};

Tue, 02 Oct 2018 14:29:45 GMT - Antoine Martin:

Thanks, applied in r20592.

Can we close this ticket?


Tue, 02 Oct 2018 14:57:18 GMT - Mark Harkin:

r20592 changes in index.html and connect.html can be removed. Otherwise this is good to close.

Thanks.


Tue, 02 Oct 2018 15:13:39 GMT - Antoine Martin: status changed; resolution set

Good catch, done in r20593.


Mon, 04 Mar 2019 12:11:41 GMT - Mark Harkin: status changed; resolution deleted

Try catch blocks without an argument were added recently. IE11 doesn't like this, fix is to add the argument:

https://github.com/mjharkin/Xpra/commit/a3258e719be86f3705a2dc57442e594493efe4d0


Mon, 04 Mar 2019 12:21:59 GMT - Antoine Martin: status changed; resolution set

Thanks! Applied in r21961.


Sat, 23 Jan 2021 05:38:44 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/1973