When running XPRA from the MinGW prompt, which on windows is my development environment Paramiko fails on "_dailog" operations.
There seem to be two problems:
With these changes things work for me. That said, I am not certain this is the right thing to do. I'll be verifying that this doesn't break Linux later today.
Antoine, can you look what I am proposing?
What about the other changes in that patch (ignoring the whitespace ones): is the or ""
needed?
We don't want to pollute default_do_get_xpra_command
with win32 concerns, it should be possible to modify path.py
in the platforms/win32
module instead.
The white spaces were a mistake. The or "" is needed because it resolves the following error:
Traceback (most recent call last): File "C:/msys64/home/nathan/src/build/lib.mingw-2.7/xpra/net/ssh.py", line 83, in exec_dialog_subprocess proc = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE, **kwargs) File "C:/msys64/mingw64/lib/python2.7/subprocess.py", line 326, in __init__ errread, errwrite) File "C:/msys64/mingw64/lib/python2.7/subprocess.py", line 532, in _execute_child args = list2cmdline(args) File "C:/msys64/mingw64/lib/python2.7/list2cmdline.py", line 51, in list2cmdline needquote = (" " in arg) or ("\t" in arg) or not arg TypeError: argument of type 'NoneType' is not iterable
Replying to Antoine Martin:
What about the other changes in that patch (ignoring the whitespace ones): is the
or ""
needed? We don't want to pollutedefault_do_get_xpra_command
with win32 concerns, it should be possible to modifypath.py
in theplatforms/win32
module instead.
Here's the current version of the patch. Seems to work, I've built and installer package that also worked. May I commit this?
May I commit this?
Sure, looks good.
I'm not sure why the icon is not found (can you run Path_info.exe
?) - but not going to worry about this for now, the patch fixes a real bug.
I believe I've fixed it in r21479. Forgot to put the ticket number in my svn log. Sorry about that, I'm not sure how to fix that, but I'll be careful going forward.
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2114