Xpra: Ticket #2137: window resizing should not be allowed under readonly mode

From #2136

Logic problem: Under --readonly=yes mode, the window is resizable and resizing of window CHANGED the desktop dimension of server.

To replicate the problem: Open two clients (--sharing=yes), one with readonly=yes. Resize the --readonly=yes window, the other window also has its size changed.

I am not very familiar with ACL of xpra since I have known it for no more than several hours (:p), and I am not sure whether --readonly=yes is security critical. Anyway this can be deemed as a bug.



Wed, 06 Feb 2019 15:13:41 GMT - Antoine Martin: status, milestone changed

the window is resizable and resizing of window CHANGED the desktop dimension of server

I assume you mean that the server-side window got resized, and this is then propagated to the other client. The desktop dimension of the server (the xvfb size) is not affected by window resizing.

We need to:


Thu, 07 Feb 2019 00:46:23 GMT - thiner:

A readonly client can just be forced to open a flag fit-to-window where all resizing of window only scale the client side view, rather than resizing the master window. :D


Thu, 07 Feb 2019 04:03:33 GMT - Antoine Martin: summary changed

A readonly client can just be forced to open a flag fit-to-window where all resizing of window only scale the client side view, rather than resizing the master window. :D

What you describe here is the same as your other ticket: #2136 Now I realize that the same applies to this ticket and that you are also using "shadow" or "start-desktop" here.

So when I said:

The desktop dimension of the server (the xvfb size) is not affected by window resizing.

That is not true of "start-desktop" servers, where we do resize the xvfb size to match the client's window size.

And this one is actually easier to solve for desktop mode.


Tue, 23 Apr 2019 14:01:16 GMT - Antoine Martin: owner, status changed

The problem with the client side is that window managers are free to ignore the hints we give them.. We try our best, but this is going to be very hard to get working perfectly.

@thiner: does that work well enough for you?


Thu, 30 May 2019 15:22:25 GMT - Antoine Martin: status changed; resolution set


Sat, 23 Jan 2021 05:43:11 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2137