Xpra: Ticket #2146: window offset when maximized

Win 10, Xpra-Python3-x86_64_Setup_2.5-r21648, on Ubuntu 16.04.5 server r20740

Started:

"C:\Program Files\Xpra\xpra_cmd" start ssh://user@ip/ --clipboard=no --webcam=no --speaker=off --microphone=off --opengl=no --start=gnome-terminal --start-new-commands=yes

When maximizing the window, there is some offset added from the top of the window (see attachment). However, everything else works normally. Going full screen (Shift+F11) "copies" the behavior from the window (on maximized, there is the offset; otherwise no)



Wed, 13 Feb 2019 13:30:38 GMT - stdedos: attachment set


Sun, 10 Mar 2019 03:13:15 GMT - Antoine Martin: owner, description changed

I believe that what you are seeing is caused by the terminal's size-hints: terminals can only be resized in multiples of the font size and when we are forced to accommodate a size which isn't a multiple of the font size, we choose the next size down from that and add padding.

You can verify this by posting the client's -d geometry log.


Sun, 10 Mar 2019 10:06:00 GMT - stdedos:

I'll try to verify later. It's just weird that it started happening sometime after server r20740 and client:py3 r21648 (but now I have no idea on the version).


Is it somehow easy that the padding is added below (and to the right, if applicable) instead of above (and left, if applicable)?


This behavior is also weird:

Going full screen (Shift+F11) "copies" the behavior from the window (on maximized, there is the offset; otherwise no)


Thu, 14 Mar 2019 15:47:40 GMT - Antoine Martin:

I have problems with GTK3: #2214, but with GTK2 the window is padded at the bottom and to the right. There is no offset at the top. The padding is consistent too: always the same no matter how I go fullscreen (F11 or Shift+F11), both from maximized or from a regular size.

@stdedos: what am I doing wrong? (tested with same OS versions as you, just the latest xpra 2.5 beta)


Thu, 14 Mar 2019 19:06:09 GMT - stdedos:

Replying to Antoine Martin:

I have problems with GTK3: #2214, but with GTK2 the window is padded at the bottom and to the right. There is no offset at the top. The padding is consistent too: always the same no matter how I go fullscreen (F11 or Shift+F11), both from maximized or from a regular size.

@stdedos: what am I doing wrong? (tested with same OS versions as you, just the latest xpra 2.5 beta)

Interestingly, I was thinking of testing it tonight myself again, since, I also found that the window is padded bottom/right.

I am not sure who's responsible for the padding (server probably?), but it must have been fixed between r20740 and r22053+ (since I updated as soon as #2198 was fixed)


Thu, 14 Mar 2019 23:21:56 GMT - Antoine Martin: status changed; resolution set


Wed, 20 Mar 2019 10:05:03 GMT - stdedos:

Verified that it was "magically" fixed sometime in-between


Sat, 23 Jan 2021 05:43:26 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2146