xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 2 years ago

Closed 2 years ago

Last modified 4 months ago

#2175 closed defect (fixed)

Websocket connection failing with reverse proxy due to incorrect Host header

Reported by: Mark Harkin Owned by: Mark Harkin
Priority: major Milestone: 2.5
Component: client Version: 2.4.x
Keywords: Cc:

Description

I can provide more details if needed but...

In xpra/net/websockets/common.py client_upgrade()

The request header for "Host" should be the server host not client host. This is causing issues when using it through a reverse proxy which is proxying based on this host header.

Tested on r21875

Change History (3)

comment:1 Changed 2 years ago by Antoine Martin

Owner: changed from Antoine Martin to Mark Harkin

Should be fixed in r21887.

@mjharkin: does that work for you?

comment:2 Changed 2 years ago by Mark Harkin

Resolution: fixed
Status: newclosed

Yes, r21887 works for me.

Thanks.

comment:3 Changed 4 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2175

Note: See TracTickets for help on using tickets.