xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Changes between Initial Version and Version 1 of Ticket #2527, comment 4


Ignore:
Timestamp:
12/29/19 20:53:44 (21 months ago)
Author:
stdedos
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2527, comment 4

    initial v1  
    3232
    3333* First capital in `invalid`, `see`
     34* Empty `xpra` (except if you want to emphasize that plain xpra is a valid command i.e. opens the GUI)
    3435* `xpra (This xpra installation`
    35 * Empty `xpra` (except if you want to emphasize that plain xpra is a valid command i.e. opens the GUI)
     36
     37I am not sure why would you write it like that:
     38
     39trunk/src/xpra/scripts/parsing.py:209
     40{{{
     41def get_usage():
     42    command_options = []
     43    if supports_server:
     44        command_options = ["start [DISPLAY]",
     45                           "start-desktop [DISPLAY]",
     46                           "upgrade [DISPLAY]",
     47                           ] + command_options
     48    if supports_shadow:
     49        command_options.append("shadow [DISPLAY]")
     50    if not supports_server:
     51        command_options.append("(This xpra installation does not support starting local servers.)")
     52}}}
     53
     54and not e.g.
     55{{{
     56def get_usage():
     57    command_options = []
     58    if not supports_server:
     59        command_options.append("(This xpra installation does not support starting local servers.)")
     60    else:  # supports_server
     61        command_options = ["start [DISPLAY]",
     62                           "start-desktop [DISPLAY]",
     63                           "upgrade [DISPLAY]",
     64                           ] + command_options
     65    if supports_shadow:
     66        command_options.append("shadow [DISPLAY]")
     67}}}
     68
     69I also don't see what is the usage of `] + command_options`.