xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 2 years ago

Closed 2 years ago

Last modified 17 months ago

#2562 closed task (fixed)

refactoring: don't keep server caps around

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 4.0
Component: client Version: 3.0.x
Keywords: Cc:

Description

Process them when we receive the hello packet then drop them.

Change History (4)

comment:1 Changed 2 years ago by Antoine Martin

Status: new → assigned

r25069: pass caps to all parsing methods

Still TODO:

  • session info uses capabilities because the client may have disabled the feature - replace with "?" if the client feature is disabled
  • verify_connected and server_disconnect_warning use the presence of the capabilities as a "was connected" indicator, replace it with a proper flag
  • command clients: pass caps as argument
Version 0, edited 2 years ago by Antoine Martin (next)

comment:2 Changed 2 years ago by Antoine Martin

Resolution: → fixed
Status: assigned → closed
  • r25111 + 25112: don't assume that the mixins are enabled
  • r25113 keep a copy of the list of packet encoders / compressors
  • r25114 move the remaining attributes we need to serverinfo mixin
  • r25115 attribute removed

comment:3 Changed 2 years ago by Antoine Martin

Caused a regression: #2599.

comment:4 Changed 17 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2562

Note: See TracTickets for help on using tickets.