Xpra: Ticket #260: Windows launcher TCP mode is broken


I can connect to Xpra sessions with the 0.8.4 Windows launcher in SSH mode without a problem, but TCP mode is broken. The launcher disappears for the moment, reappears with "command terminated OK" message.

Connecting to the same session using the Linux launcher and current SVN works fine.

The server on the other side is 0.8.1. Help appreciated!

Thu, 14 Feb 2013 16:10:51 GMT - Antoine Martin:

I test TCP mode very regularly (more often than SSH mode), so this must really be one of the last few changes - can you try 0.8.2 to narrow it down further?

Also, is it broken if you use the command line version or just using the launcher?

Tue, 19 Feb 2013 10:10:09 GMT - ahuillet:

0.8.2 : launcher doesn't work in TCP mode, with a correct or incorrect password (haven't tried without any password).

Works with commandline version though.

Tue, 19 Feb 2013 22:51:11 GMT - alas:

It works ok in TCP mode without a password, on Windows 7 Pro, both with 0.8.2 and 0.8.4

Wed, 20 Feb 2013 09:43:29 GMT - Antoine Martin:

Does this patch fix the issue (applies both to trunk and v0.8.x branch):

--- src/xpra/scripts/client_launcher.py	(revision 2745)
+++ src/xpra/scripts/client_launcher.py	(working copy)
@@ -566,7 +566,7 @@
 	def do_connect(self):
-		if xpra_opts.mode=="tcp" and not sys.platform.startswith("win"):
+		if xpra_opts.mode=="tcp":
 			""" Use built-in connector (faster and gives feedback) - does not work on win32... (dunno why) """

works or me(tm)

Wed, 20 Feb 2013 10:02:32 GMT - ahuillet:

Patch makes the launcher work OK for TCP sessions with password - but not with a config file when autoconnect=True!

Wed, 20 Feb 2013 10:08:37 GMT - ahuillet:

Note that autoconnect=True doesn't work without the patch either.

So the patch does seem to fix part of the issue.

Wed, 20 Feb 2013 10:10:23 GMT - Antoine Martin:

OK, so I've committed the patch as r2754 + r2755 (for 0.8.x)

Now, on to figure out the auto-connect thing... (I really hope that was not the reason for the win32 workaround..)

Wed, 20 Feb 2013 12:03:39 GMT - Antoine Martin: attachment set

use the standard codepath for launching with autoconnect (breaks ssh..)

Wed, 20 Feb 2013 16:15:34 GMT - Antoine Martin: attachment set

better cleanup, ssh works but socket timeout does not :(

Thu, 21 Feb 2013 08:07:44 GMT - Antoine Martin: attachment set

updated patch with cruft removed

Thu, 21 Feb 2013 08:08:43 GMT - Antoine Martin:

Please test the updated v4 patch against trunk, on win32 and also on other platforms just to be safe, also using config files for launching.

Thu, 21 Feb 2013 08:42:56 GMT - Antoine Martin: attachment set

updated patch fixing username option, can be specified in two ways: username@host or username field in gui (the former takes precedence)

Thu, 21 Feb 2013 10:56:34 GMT - ahuillet:

With the patch nr. 5:

win32, TCP mode, config file, autoconnect = True : works win32, TCP mode, config file, autoconnect = False : works win32, TCP mode, details in GUI : works

Thu, 21 Feb 2013 12:33:24 GMT - Antoine Martin:

Committed v6 (minor tweaks) in r2762 - please help with testing! (will then backport to v0.8.x)

What we want to test:

For those testing and unsure about what auto-connect is, one can create session files (and the launcher will eventually gain the ability to edit and save those files). These files are associated with the xpra_launcher application via extension lookup / mime-types (except on osx) so double-clicking on them should fire up the launcher, and if the file has autoconnect = True then the launcher will connect automatically without first showing the GUI. One can also do this by hand from the command line, which is better for debugging/testing, ie:

xpra_launcher /path/to/session1.xpra

Or on win32:

Xpra_Launcher.exe C:\path\to\session1.xpra

The extension for those files is .xpra and they should look something like this:


Fri, 22 Feb 2013 12:10:14 GMT - ahuillet:

Confirmed working in 0.8.6rc : TCP mode both with and without config file as well as SSH mode without config file.

Fri, 22 Feb 2013 12:11:58 GMT - Antoine Martin: status changed; resolution set

backported to v0.8.x in r2764

Closing at last!

Sat, 23 Jan 2021 04:49:52 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/260