xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 2 years ago

Closed 2 years ago

Last modified 16 months ago

#2608 closed enhancement (fixed)

[PATCH] Small FreeBSD tweaks

Reported by: arrowd Owned by: arrowd
Priority: trivial Milestone: 4.0
Component: platforms Version: trunk
Keywords: Cc:

Description

Here are some patches we have to apply to our x11/xpra port.

Attachments (1)

xpra.patch (2.1 KB) - added by arrowd 2 years ago.

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by arrowd

Attachment: xpra.patch added

comment:1 Changed 2 years ago by Antoine Martin

Owner: changed from Antoine Martin to arrowd

I've merged the easy part in r25318.

AFAICT, the cups part of this patch is not correct and would change the cups backend path for for non-!FreeBSD to /usr/libexec/cups.

comment:2 Changed 2 years ago by arrowd

Oh, right, this hunk is plainly wrong. Please, discard it.

comment:3 Changed 2 years ago by arrowd

Can you please also change

if is_Fedora() or is_CentOS() or is_RedHat():

line to

if is_Fedora() or is_CentOS() or is_RedHat() or FREEBSD:

?

Last edited 2 years ago by Antoine Martin (previous) (diff)

comment:4 Changed 2 years ago by Antoine Martin

use libexec on FreeBSD : r25319.

comment:5 Changed 2 years ago by Antoine Martin

Do you still need the change for cups?
Something like this perhaps:

@@ -1506,7 +1506,10 @@
 
             if printing_ENABLED and POSIX:
                 #install "/usr/lib/cups/backend" with 0700 permissions:
-                copytodir("cups/xpraforwarder", "lib/cups/backend", chmod=0o700)
+                lib_cups = "lib/cups"
+                if FREEBSD:
+                    lib_cups = "libexec/cups"
+                copytodir("cups/xpraforwarder", "%s/backend" % lib_cups, chmod=0o700)
 
             if x11_ENABLED:
                 #install xpra_Xdummy if we need it:

comment:6 Changed 2 years ago by arrowd

Of course, that'd be great.

comment:7 Changed 2 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

r25320 for cups path.

That's all of it.

comment:8 Changed 2 years ago by Antoine Martin

FYI: these patches are now in the v3.0.x branch and will be included in 3.0.7: r25321.

comment:9 Changed 16 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2608

Note: See TracTickets for help on using tickets.