xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 2 years ago

Last modified 16 months ago

#2615 assigned task

replace javascript crypto library with jsSHA

Reported by: Antoine Martin Owned by: Antoine Martin
Priority: major Milestone: 4.2
Component: network Version: 3.0.x
Keywords: Cc:

Description

​jsSHA looks much more compact than ​forge.

Attachments (1)

asmcrypto.patch​ (6.4 KB) - added by Antoine Martin 23 months ago.
attempting to switch over

Download all attachments as: .zip

Change History (6)

comment:1 Changed 2 years ago by Antoine Martin

Status: new → assigned

This may help with #2799.

comment:2 Changed 23 months ago by Antoine Martin

jsSHA is great and could be used for hmac authentication, but it doesn't handle AES...
So maybe we can just use the ​crypto API and drop IE11 support.

Examples here: ​webcrypto-examples.

comment:3 Changed 23 months ago by Antoine Martin

Big problem with browser crypto is that this relies on asynchronous promises, which would require a huge rewrite of the protocol layer which is sequential by nature.

Maybe ​asmcrypto.js instead? It handles both AES and HMAC with a synchronous API. (and ​this fork has documentation)

Last edited 23 months ago by Antoine Martin (previous) (diff)

Changed 23 months ago by Antoine Martin

Attachment: asmcrypto.patch​ added

attempting to switch over

comment:4 Changed 20 months ago by Antoine Martin

Milestone: 4.1 → 4.2

comment:5 Changed 16 months ago by migration script

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/2615

Note: See TracTickets for help on using tickets.