Xpra: Ticket #2701: changes to JS
I made some small changes to JS:
- use let/const instead of var
- insert missing/remove extra semicolons
- declare some vars
The patches are attached.
Are there guidelines for JS formatting? I can't identify a consistent style :)
Wed, 01 Apr 2020 17:06:54 GMT - brief: attachment set
set to var-let-const.patch
Wed, 01 Apr 2020 17:20:07 GMT - brief:
Line breaks broke the patch.
Wed, 01 Apr 2020 17:20:27 GMT - brief: attachment set
set to add-remove-semicolons2.patch
Wed, 01 Apr 2020 17:20:35 GMT - brief: attachment set
set to missing-declaration2.patch
Thu, 02 Apr 2020 04:04:06 GMT - Antoine Martin: status changed; resolution set
changed from new to closed
set to fixed
Awesome, thank you!
Applied in r25908 + r25909 + r25910.
Thu, 02 Apr 2020 15:57:42 GMT - stdedos:
@Antoine: If interested, you could use ESLint (https://eslint.org/) for this part of the project.
It's easy to inherit the "recommended" configuration, and/or other's template configuration - and you can still make it as much opinionated as you want.
Sat, 23 Jan 2021 05:58:28 GMT - migration script:
this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/2701