xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.


Opened 8 years ago

Closed 8 years ago

Last modified 5 months ago

#308 closed defect (fixed)

Ping timeout if client and server have different times

Reported by: Joel Martin Owned by: Antoine Martin
Priority: major Milestone: 0.9
Component: server Version: trunk
Keywords: ping timeout Cc:

Description

For the server, the updating of last_ping_echoed_time is happening in the process_ping rather than process_ping_echo. This will work as long as both client and server have times set to the same minute because the the ping from the client will update the server's last_ping_echoed time to something that will keep it from timing out the client.

I will attach a patch that moves the updating of last_ping_echoed_time to process_ping_echo in the server. The client's ping code looks okay to me.

Attachments (1)

server_ping.patch (847 bytes) - added by Joel Martin 8 years ago.
Move update of last_ping_echoed_time to the correct handler

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Joel Martin

Attachment: server_ping.patch added

Move update of last_ping_echoed_time to the correct handler

comment:1 Changed 8 years ago by Antoine Martin

Resolution: fixed
Status: newclosed

Applied in r3056 - Thanks!

comment:2 Changed 5 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/308

Note: See TracTickets for help on using tickets.