Xpra: Ticket #308: Ping timeout if client and server have different times

For the server, the updating of last_ping_echoed_time is happening in the process_ping rather than process_ping_echo. This will work as long as both client and server have times set to the same minute because the the ping from the client will update the server's last_ping_echoed time to something that will keep it from timing out the client.

I will attach a patch that moves the updating of last_ping_echoed_time to process_ping_echo in the server. The client's ping code looks okay to me.



Fri, 12 Apr 2013 15:46:08 GMT - Joel Martin: attachment set

Move update of last_ping_echoed_time to the correct handler


Fri, 12 Apr 2013 15:56:17 GMT - Antoine Martin: status changed; resolution set

Applied in r3056 - Thanks!


Sat, 23 Jan 2021 04:51:17 GMT - migration script:

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/308