xpra icon
Bug tracker and wiki

This bug tracker and wiki are being discontinued
please use https://github.com/Xpra-org/xpra instead.

Opened 9 years ago

Closed 9 years ago

Last modified 12 months ago

#325 closed defect (fixed)

TypeError: send_min_quality() takes exactly 1 argument (2 given)

Reported by: Mark Hills Owned by: Antoine Martin
Priority: major Milestone: 0.9
Component: client Version:
Keywords: Cc:


I see this error at the client. It looks like a code change.
Here's a patch to fix it. I hope that I understood the use of the min_quality attribute correctly.

Index: xpra/platform/client_extras_base.py
--- xpra/platform/client_extras_base.py	(revision 3140)
+++ xpra/platform/client_extras_base.py	(working copy)
@@ -672,7 +672,7 @@
             if q!=self.client.min_quality:
                 log.debug("setting minimum picture quality to %s", q)
                 self.client.min_quality = q
-                self.client.send_min_quality(q)
+                self.client.send_min_quality()
         for q in sorted(quality_options):
             qi = CheckMenuItem("%s%%" % q)
Index: xpra/client.py
--- xpra/client.py	(revision 3140)
+++ xpra/client.py	(working copy)
@@ -233,8 +233,8 @@
                 q -= 10
             elif bw < self.max_bandwidth:
                 q += 5
-            q = max(10, min(95 ,q))
-            self.send_min_quality(q)
+            self.min_quality = max(10, min(95 ,q))
+            self.send_min_quality()
             return True
         if (self.max_bandwidth):
             self.last_input_bytecount = 0

Change History (2)

comment:1 Changed 9 years ago by Antoine Martin

Component: androidclient
Resolution: fixed
Status: newclosed

Spot on!

Applied in r3141 - Thanks!

comment:2 Changed 12 months ago by migration script

this ticket has been moved to: https://github.com/Xpra-org/xpra/issues/325

Note: See TracTickets for help on using tickets.