window icon goes missing when resuming

[Antoine Martin]

This only affects some apps (vbox, ensight,..) and only when started from another app (a terminal is the easiest way):

• start a session with xterm
• start VirtualBox from xterm (or other terminal app) - the vbox window has the correct vbox icon
• disconnect
• re-connect - the terminal window icon is correct but the vbox window uses same icon as the terminal window!?

I've tried:

• disabling self.raw_window_icons so the icon would be sent with the metadata rather than after (in case it was a window setup race) - no effect
• saving the window icon to file on the client side to verify that we are sending the correct one with:

  pixbuf.save("window-icon%s.png" % time.time(), "png")
  

• starting vbox directly (without a terminal) shows the correct icon every time

I'm out of ideas!

[Antoine Martin]

And now I can't reproduce it anymore.
But before that, the prime suspect was the group-leader code.

[Antoine Martin]

Can reproduce like so:

• start xterm
• start calculator from xterm
• disconnect
• resume

The calculator will end up with the same window icon as the xterm

[Antoine Martin]

It was a race, which explains why only some applications showed the problem some of the time.

Fixed in r3787

[migration script]

this ticket has been moved to: ​https://github.com/Xpra-org/xpra/issues/359